You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 23, 2023. It is now read-only.
It looks to me like #121 included a lot of changes after refactoring (19 files in total), and my bet is that NoopSpanBuilder was forgotten all along (I think this because in the PR/Issue there's no mention of NoopSpanBuilder).
I tried updating the code to remove that implements SpanContext + minor tuning, and everything works just fine, so I could finish the patch up and send it as a final fix piece.
Does it make sense to you guys? @yurishkuro@bhs (author of #121) You may remember it better ;)
@carlosalberto@cwe1ss sorry for the delay! I don't know why that inheritance relationship would still be necessary. If everything compiles without it, we should def remove. Thanks for asking.
Hi! I'm working on the C# version of opentracing-noop and I've seen that
NoopSpanBuilder
extends NoopSpanContext.Is there still any use for this or is this no longer necessary due to #55, #121 ?
The text was updated successfully, but these errors were encountered: