Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Should NoopSpanBuilder still extend NoopSpanContext? #255

Closed
cwe1ss opened this issue Feb 7, 2018 · 2 comments · Fixed by #290
Closed

Should NoopSpanBuilder still extend NoopSpanContext? #255

cwe1ss opened this issue Feb 7, 2018 · 2 comments · Fixed by #290
Labels

Comments

@cwe1ss
Copy link
Member

cwe1ss commented Feb 7, 2018

Hi! I'm working on the C# version of opentracing-noop and I've seen that NoopSpanBuilder extends NoopSpanContext.

Is there still any use for this or is this no longer necessary due to #55, #121 ?

@carlosalberto
Copy link
Collaborator

Hey @cwe1ss

It looks to me like #121 included a lot of changes after refactoring (19 files in total), and my bet is that NoopSpanBuilder was forgotten all along (I think this because in the PR/Issue there's no mention of NoopSpanBuilder).

I tried updating the code to remove that implements SpanContext + minor tuning, and everything works just fine, so I could finish the patch up and send it as a final fix piece.

Does it make sense to you guys? @yurishkuro @bhs (author of #121) You may remember it better ;)

@bhs
Copy link
Contributor

bhs commented Jul 16, 2018

@carlosalberto @cwe1ss sorry for the delay! I don't know why that inheritance relationship would still be necessary. If everything compiles without it, we should def remove. Thanks for asking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants