This repository has been archived by the owner on May 23, 2023. It is now read-only.
Address two main sources of cruft in opentracing-java #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not needed by callers and only exists as a convenience to Tracer implementations; that said, no known Tracer implementation uses the opentracing-impl module, and even if they did it could live in opentracing-contrib somewhere.
Now that the opentracing-impl module has been removed, this is trivial to address.
|
I def won't merge this for at least a couple of days in case this angers anybody :) |
objectiser
approved these changes
Apr 16, 2017
|
Given the apparent unanimity here, I am just going to merge this so that the #115 review will be easier to read. |
This was referenced Apr 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two goals:
Tracer.SpanBuilderandSpanContext(which has baffled many people and frankly never made sense to me). Closes Why does Tracer.SpanBuilder extend SpanContext? #55.opentracing-implmodule entirely. The coreopentracing-javagithub repo should be as lean as possible and exists to define the OpenTracing API contract for callers; it is not intended to be a source of helper code forTracerimplementations: such a thing might be valuable, but would be better place into a repo in theopentracing-contriborganization. Also, no known productionTracerimplementations actually useopentracing-impl, nor doesopentracing-mock. Closes Rename-impland-impl-java8modules to better reflect what they are #46. Closes Reorganize modules #44 (... or at least makes it obsolete).cc @yurishkuro @pavolloffay @objectiser @wu-sheng @sjoerdtalsma who have expressed enthusiasm about various pieces of this in the past. I was thinking it would be nice to merge this before #115, as that PR would be simpler without the -impl stuff getting in the way.
Also cc @michaelsembwever who has been MIA for a while but probably won't like this. :-/ I would like to give you an opportunity to argue against it.