Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

update license to Apache 2.0 #181

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

eirinikos
Copy link
Contributor

This commit replaces the MIT license with the Apache 2.0 license.

(All CNCF projects should use the Apache License 2.0 - please see opentracing/specification#61 for context.)

Note:

  • none of the existing files has a license header, so I haven't added any headers in this commit.
  • I have preserved the copyright as Copyright 2016 The OpenTracing Authors. Should the year be listed as 2018 instead?

Please air any objections by April 3rd, thanks!

CCing @dankohn

CCing previous contributors: @bhs @tschottdorf @yurishkuro @bg451 @jmacd @slimsag @basvanbeek @cce @stamm @RaduBerinde @gwik @sebastianvera @IncSW @bradbl @kyleconroy @bmizerany @RichardScothern @tamird @PikBot @ror6ax @dvrkps @NeoCN @savaki @rohanpai @tedsuo @billf @voutasaurus @kriskowal

@bhs
Copy link
Contributor

bhs commented Mar 27, 2018

@eirinikos looks good to me, though we should def wait to see if others object!

Re the copyright year, I think the convention would be Copyright 2016-2018 The OpenTracing Authors, but I am definitely not an expert (that's just what I've seen).

@dankohn
Copy link

dankohn commented Mar 27, 2018

We would recommend leaving off the year -- Copyright The OpenTracing Authors -- though it's not essential.

@slimsag
Copy link
Contributor

slimsag commented Mar 28, 2018

I am fine with this change, but I am a bit worried with how it will be carried out. As far as I know (IANAL), you cannot simply "ask for objections" before relicensing a project even if the licenses are similar in nature.

Any prior contributor to this project released their contribution under the MIT license terms, one of which is:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

So it stands to reason that we would need the approval of every prior contributor to make this change, or we must continue to distribute the MIT license "in all copies or substantial portions of the Software."

Likewise, we can't simply say all prior contributions are under the Apache 2.0 license unless we establish those contributor's intent / approval to relicense their contributions under the new license.

So, I'm totally fine with this change, and I'm a big fan of the Apache 2.0 license -- but doing this without some form of explicit permission from each contributor (PR approval here, etc) is a legal minefield IMHO.

@bhs
Copy link
Contributor

bhs commented Mar 28, 2018

@slimsag:

but doing this without some form of explicit permission from each contributor (PR approval here, etc) is a legal minefield IMHO.

IAAlsoNAL, but my understanding from conversations with a variety of people who know about these matters suggests that it is, in fact, ok... you can read a little more at opentracing/specification#61.

@eirinikos
Copy link
Contributor Author

@bhs 👋

For whatever reason, Licensee is still not identifying this repo's license type as Apache 2.0. (Licensee being the tool that GitHub uses to tag repositories with their license types.)

Could we hold off on merging this PR until I push a new commit to fix the problem? I hope to have a solution in the next day or so.

(Right now, this problem affects OT-Go, OT-Objc, OT-PHP, and OT-Ruby.)

@yurishkuro
Copy link
Member

yurishkuro commented Apr 3, 2018

For whatever reason, Licensee is still not identifying this repo's license type as Apache 2.0

it wouldn't until the PR is merged.

@eirinikos
Copy link
Contributor Author

it wouldn't until the PR is merge.

I'm testing changes locally.

Replace MIT license with Apache 2.0 license.
@eirinikos
Copy link
Contributor Author

For some reason, in some situations, using a # License header in a repo's README will cause Licensee to scan the README as a license file.

Replacing # License with ## Licensing allows us to bypass this problem.

If there are no objections to switching to Apache 2.0, then this PR is ready for a merge tomorrow!

@bhs bhs merged commit 5a4c9c6 into opentracing:master Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants