-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
Replace MIT license with Apache 2.0 license. Signed-off-by: Andrea Kao <eirinikos@gmail.com>
@@ -6,3 +6,7 @@ The Go incarnation of the cross-platform "BasicTracer" reference implementation | |||
## Status | |||
|
|||
In early development: there will be backwards-incompatible changes so _caveat emptor_ for now! | |||
|
|||
## Licensing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License
would work better instead of Licensing
, to match the suffix of the actual license name Apache 2.0 License
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I used Licensing
, though, because License
would cause Licensee to scan the README as if it were a License file in itself. This issue was discovered with several other OT repos (please see opentracing/opentracing-go#181 (comment)).
Another solution is to omit any mention of the license from the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jaeger uses the word License as the header, and GitHub recognizes the type just fine, e.g. https://github.com/jaegertracing/documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm not sure why Licensee sometimes recognizes the type (when License
is in the header) and sometimes it doesn't.
I didn't encounter this problem when I made changes with OT-cpp or OT-py. When I tested those changes locally, Licensee recognized the type just fine (even with License
in the README header).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my advice is to ignore Licensee and use the text that what makes most sense. If github doesn't display it correctly afterwards, we can open a ticket with them to have it fixed (since it's working for other repos, and the actual LICENSE file is unambiguous).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro GitHub just runs vanilla Licensee. That lets @eirinikos test and find the smallest possible changes that will get GitHub to correctly recognize the license.
Replace MIT license with Apache 2.0 license.
(All CNCF projects should use the Apache License 2.0 - see opentracing/specification#61 for context.)
We'd like to give previous contributors a 7-day period to air any objections.
(If you have any concerns or feedback, please post a comment here by April 12. Thanks!)
CCing @dankohn @bhs
CCing previous contributors: @tschottdorf @bg451 @RaduBerinde @yurishkuro @nimeshksingh @dvrkps @jmacd @chris-ramon @cce