fix: switch page or block should clear selection

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

【问题描述】

切换页面或者区块的时候，原来选择的组件边框未消失

【问题分析】

切换页面或者区块的时候，画布会重新渲染，选中框此时应该清空选择。

【问题修复方案】

切换页面或者区块的时候，清空选择

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved schema import process by automatically clearing canvas selections after importing a new schema, preventing potential UI inconsistencies.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the importSchema function in the useCanvas.js file. The change adds a line to clear canvas selections immediately after importing a schema. This ensures that any previous selections are removed when a new schema is imported, potentially preventing UI inconsistencies or unexpected behavior related to canvas state management.

Changes

File	Change Summary
packages/canvas/DesignCanvas/src/api/useCanvas.js	Modified importSchema function to add canvasApi.value?.clearSelect?.() after resetting canvas state

Suggested labels

bug

Suggested reviewers

• hexqi

Possibly related PRs

• fix: block switch select property failed #984: Modifies addPropertyLinks function in useProperty.js, potentially related to canvas property handling
• fix: cannot publish current editing block #987: Updates refreshBlockData function in blockSetting.jsx, involving block property synchronization
• fix: preview page breadcrumb don't exist useBlock method and preview block error when type undefined #988: Modifies currentBlock computed property in Main.vue, related to block state and selection management

Poem

🎨 A canvas cleared, selections swept away,
Rabbit hops through code with glee today!
Import schema, state reset with care,
No lingering ghosts of selections there! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b38af9f and dafa90a.

📒 Files selected for processing (1)

• packages/canvas/DesignCanvas/src/api/useCanvas.js (1 hunks)

🔇 Additional comments (1)

packages/canvas/DesignCanvas/src/api/useCanvas.js (1)

143-143: Ensure clearing selection aligns with user expectations.

Calling canvasApi.value?.clearSelect?.() immediately after resetting the canvas state is a clean way to avoid leftover selections from the previous schema. However, confirm that this behavior is indeed desired in all scenarios. If certain user interactions must preserve existing selections, consider conditionally clearing them based on context.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.