fix: block switch select property failed #984

chilingling · 2025-01-02T03:15:43Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Refactor
- Updated internal property merging mechanism to use Object.assign instead of a previous method.

coderabbitai · 2025-01-02T03:15:51Z

Walkthrough

The pull request modifies the addPropertyLinks function in the useProperty.js file, replacing the extend function with Object.assign for merging properties. This change directly updates the property object by assigning linked and widget properties using Object.assign, potentially altering how component properties are updated while maintaining the existing function's overall structure and logic.

Changes

File	Change Summary
`packages/settings/props/src/composable/useProperty.js`	Replaced `extend` function with `Object.assign` for merging properties into the `property` object

Possibly related PRs

fix: basePropsGroup use deepclone prevent clone array itself #975: Changes in useMaterial.js involving property cloning, which could be conceptually related to property handling in useProperty.js

Suggested reviewers

hexqi

Poem

🐰 Hop, hop, code refactor time!
Object.assign now takes the prime
Extending props with rabbit's might
Merging changes, clean and tight
A small tweak in the property line 🔧

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hexqi · 2025-01-02T03:20:02Z

packages/settings/props/src/composable/useProperty.js

@@ -26,7 +25,7 @@ const addPropertyLinks = ({ linked, propertyName, componentProperties }) => {
      const property = propertyList[j]

      if (property.property === propertyName) {
-        propertyList[j] = extend(true, {}, property, {
+        propertyList[j] = Object.assign(property, {


property就是propertyList[j]，这个赋值是不是没什么必要

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/settings/props/src/composable/useProperty.js (1)

28-28: Use caution with direct mutation of the property object.
By using Object.assign() on the existing property object, you are mutating it in place, which may cause unintended side effects elsewhere if property is referenced in other parts of the code. Consider using an immutable update approach—e.g., Object.assign({}, property, { ... })—if maintaining immutability is a concern.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8467dbd and cef41b2.

📒 Files selected for processing (1)

packages/settings/props/src/composable/useProperty.js (1 hunks)

* fix: block switch select property failed * fix: del assignment

fix: block switch select property failed

6247efb

chilingling changed the title ~~chore: update version to 2.1.0-rc.0 (#947)~~ fix: block switch select property failed Jan 2, 2025

github-actions bot added the bug Something isn't working label Jan 2, 2025

hexqi reviewed Jan 2, 2025

View reviewed changes

fix: del assignment

cef41b2

hexqi approved these changes Jan 2, 2025

View reviewed changes

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

hexqi merged commit fdee3f2 into opentiny:release/v2.1.0 Jan 2, 2025
2 checks passed

chilingling added a commit that referenced this pull request Jan 3, 2025

fix: block switch select property failed (#984)

ff5048d

* fix: block switch select property failed * fix: del assignment

coderabbitai bot mentioned this pull request Jan 6, 2025

fix: switch page or block should clear selection #992

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: block switch select property failed #984

fix: block switch select property failed #984

chilingling commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

hexqi Jan 2, 2025

coderabbitai bot left a comment

fix: block switch select property failed #984

fix: block switch select property failed #984

Conversation

chilingling commented Jan 2, 2025 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

Background and solution

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented Jan 2, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

hexqi Jan 2, 2025

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

chilingling commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)