Refactor python3-observabilityclient package setup in tcib_packages #122

son-vyas · 2024-01-24T05:32:29Z

This commit makes two significant changes to tcib pkg configuration:

Removes the 'python3-observabilityclient' package from the common configuration. This step is taken to streamline the package setup and tailor the dependencies more specifically to the needs of different architectures and operating systems.
Adds the 'python3-observabilityclient' package specifically for x86_64 and el8 architectures. This addition aligns with our strategy to optimize and enhance observability and monitoring capabilities on these architectures.

Additionally, a note is included to address future RHEL-specific package requirements, indicating that RHEL-specific packages can be added or uncommented once they are available.
This change prepares for a more tailored and efficient package management approach in our system configurations.

This commit makes two significant changes to tcib pkg configuration: 1. Removes the 'python3-observabilityclient' package from the common configuration. This step is taken to streamline the package setup and tailor the dependencies more specifically to the needs of different architectures and operating systems. 2. Adds the 'python3-observabilityclient' package specifically for x86_64 and el8 architectures. This addition aligns with our strategy to optimize and enhance observability and monitoring capabilities on these architectures. Additionally, a note is included to address future RHEL-specific package requirements, indicating that RHEL-specific packages can be added or uncommented once they are available. This change prepares for a more tailored and efficient package management approach in our system configurations.

openshift-ci · 2024-01-24T05:32:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: son-vyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [son-vyas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marios · 2024-01-24T07:10:32Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs


what will be uncommented here?

do you mean more like "we can add rhel specific pkgs to this list"

[EDIT]: ok i see what you mean now. we can uncomment "rhel:" specifically to add a new 'rhel' key and package list

we shoudl not have rhel sepfcic packages in this file this is intended to work on both centos and rhel.

and we do not expect people to edit the file so i dont think this comment is relevent

marios · 2024-01-24T07:17:07Z

container-images/tcib/base/openstackclient/openstackclient.yaml

+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient
+  el8:


how/where are these 'architectures' decided. el8 is operating system specific and x86_64 is cpu architecture specific. how/where is this going to be used

So, we had an issue with python3-observabilityclient pkg which we dont need in rhel now - https://redhat-internal.slack.com/archives/C04HN4L5XHV/p1706022079814729. So we want to follow the same pattern we followed with https://opendev.org/openstack/tripleo-common/src/branch/master/container-images/tcib/base/collectd/collectd.yaml#L50 to get this package excluded in rhel.

ok thanks for the extra info.

as we discussed in yesterday's review call, lets keep only the one we need here (e.g. "el9" or "rhel9" or something similar) and then we will also need some further work to wire it up so that we get the right packages for rhel9

we should not have any el8 related content we will be building this for 9.4

observabilityclient is not built on el8, only for newer releases.

softwarefactory-project-zuul · 2024-01-24T07:33:52Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6e1015a91d5b43cebe73bc2303a49dcb

✔️ tcib-build-containers SUCCESS in 2h 00m 17s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 1h 14m 48s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 21m 20s

arxcruz

Is this really work? I am checking the tcib python code, and I can't see anywhere differentiating

arxcruz · 2024-01-24T13:27:45Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient


This will not install it on centos9 upstream, unless we have something like this https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/tcib/base/os/nova-base/nova-libvirt/nova-libvirt.yaml#L2 here in tcib_actions. The bright side is, it will also not be installed in downstream.

does python3-observabilityclient provide an oepnstack client plugin? if not I'm not sure this is strictly in the scope fo this container image.

its not intended to have a set of generic debugging clients for example this container is not expect to have ssh or virsh for example to act as a way to debug the comptue nodes or even run must-gather or sosreports.

yes, it provides an openstack client plugin.

marios · 2024-01-25T07:38:52Z

container-images/tcib/base/openstackclient/openstackclient.yaml

+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient
+  el8:


ok thanks for the extra info.

as we discussed in yesterday's review call, lets keep only the one we need here (e.g. "el9" or "rhel9" or something similar) and then we will also need some further work to wire it up so that we get the right packages for rhel9

marios · 2024-01-25T07:39:48Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:


(this one can be removed as discussed yesterday, we don't want/need to distinguish on cpu arch here)

paramite · 2024-01-30T10:41:16Z

This package is already available in RDO all the way back down to Antelope release and also available in downstream for RHEL9. IMO the PR for observabilityclient should be reverted now.

paramite

IMO this is not needed any more as the package is available both for upstream and downstream.

SeanMooney · 2024-03-01T13:28:41Z

container-images/tcib/base/openstackclient/openstackclient.yaml

+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient
+  el8:


we should not have any el8 related content we will be building this for 9.4

SeanMooney · 2024-03-01T13:30:51Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient


does python3-observabilityclient provide an oepnstack client plugin? if not I'm not sure this is strictly in the scope fo this container image.

its not intended to have a set of generic debugging clients for example this container is not expect to have ssh or virsh for example to act as a way to debug the comptue nodes or even run must-gather or sosreports.

SeanMooney · 2024-03-01T13:55:18Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs


we shoudl not have rhel sepfcic packages in this file this is intended to work on both centos and rhel.

and we do not expect people to edit the file so i dont think this comment is relevent

mrunge

I am not sold to this approach here.

mrunge · 2024-03-01T14:33:20Z

container-images/tcib/base/openstackclient/openstackclient.yaml

  - python3-octaviaclient
  - python3-aodhclient
  - bash-completion
  - iputils
+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient


yes, it provides an openstack client plugin.

mrunge · 2024-03-01T14:39:24Z

container-images/tcib/base/openstackclient/openstackclient.yaml

+  #rhel: We can uncomment this when we have rhel specific pkgs
+  x86_64:
+  - python3-observabilityclient
+  el8:


observabilityclient is not built on el8, only for newer releases.

openshift-ci bot requested review from rabi and viroel January 24, 2024 05:32

openshift-ci bot added the approved label Jan 24, 2024

marios reviewed Jan 24, 2024

View reviewed changes

arxcruz reviewed Jan 24, 2024

View reviewed changes

marios requested changes Jan 25, 2024

View reviewed changes

openshift-ci bot assigned marios Jan 25, 2024

marios reviewed Jan 25, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase label Jan 26, 2024

vyzigold mentioned this pull request Jan 30, 2024

Add observabilityclient config to env vars openstack-k8s-operators/openstack-operator#643

Merged

paramite requested changes Jan 30, 2024

View reviewed changes

openshift-ci bot assigned paramite Jan 30, 2024

openshift-merge-robot removed the needs-rebase label Feb 6, 2024

SeanMooney requested changes Mar 1, 2024

View reviewed changes

openshift-ci bot assigned SeanMooney Mar 1, 2024

mrunge reviewed Mar 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor python3-observabilityclient package setup in tcib_packages #122

Refactor python3-observabilityclient package setup in tcib_packages #122

son-vyas commented Jan 24, 2024

openshift-ci bot commented Jan 24, 2024

marios Jan 24, 2024

SeanMooney Mar 1, 2024

marios Jan 24, 2024

son-vyas Jan 24, 2024

marios Jan 25, 2024

SeanMooney Mar 1, 2024

mrunge Mar 1, 2024

softwarefactory-project-zuul bot commented Jan 24, 2024

arxcruz left a comment

arxcruz Jan 24, 2024

SeanMooney Mar 1, 2024

mrunge Mar 1, 2024

marios Jan 25, 2024

marios Jan 25, 2024

paramite commented Jan 30, 2024

paramite left a comment

SeanMooney Mar 1, 2024

SeanMooney Mar 1, 2024

SeanMooney Mar 1, 2024

mrunge left a comment

mrunge Mar 1, 2024

mrunge Mar 1, 2024

Refactor python3-observabilityclient package setup in tcib_packages #122

Are you sure you want to change the base?

Refactor python3-observabilityclient package setup in tcib_packages #122

Conversation

son-vyas commented Jan 24, 2024

openshift-ci bot commented Jan 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jan 24, 2024

arxcruz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paramite commented Jan 30, 2024

paramite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrunge left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment