-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observabilityclient config to env vars #643
Add observabilityclient config to env vars #643
Conversation
Work on readding observabilityclient to the image is ongoing here: openstack-k8s-operators/tcib#122 |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/965b7a22e8ca443faf729ee8017db007 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 51s |
I think the issue might be, that the added telemetry-operator dependency is too new and the operators in go.mod need to be updated first. I added a depends-on on that PR. I'll take a look at this once that's merged. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/af9a772b5ace4ae9804bd25f9549b741 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 19s |
/lgtm |
1fa69b8
to
5e2f934
Compare
I rebased on top of main |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/31fc2a45998f45c087494b5f337f006f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 55s |
recheck
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/037b28903b28413ca2ca5860a43439fb ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 13s |
recheck
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4e8523b0418e4053b3a7e1e2989407cd ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 35s |
recheck |
1 similar comment
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a6304f875c7646eabab0cf9524456331 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 17s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e9ab743407754bd6a51424c1e5d00d49 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 56s |
recheck
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9396756e4e3048bea1284185b19c8c03 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 52s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1bf7e2237071466aacabd1a725365a7e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 49s |
5e2f934
to
2a33139
Compare
I squashed the commits, rebased on top of main and used the latest telemetry-operator api. This allowed me to drop the dependency on the telemetry-operator. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1f37ab3c04f64ebbb57c3c1319136449 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 43s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/455e7f60a7a54326b8b7e3d509a82211 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 14s |
recheck
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/762ee317f32745e3aa9a9c1b8912b4cf ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 26s |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
54aa7fa
to
d4fe388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, jlarriba, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a136dbd
into
openstack-k8s-operators:main
This adds the needed variables for the observabilityclient to work. Observabilityclient allows to execute
openstack metric
command for interacting with prometheus deployed as part of telemetry MetricStorage by the telemetry-operator.I should note that the observabilityclient currently isn't available in the openstackclient container image, so the
openstack metric
commands aren't available at the moment without manually installing it. But the PR itself doesn't require observabilityclient installed on the container.Depends-On: #641