Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observabilityclient config to env vars #643

Conversation

vyzigold
Copy link
Contributor

@vyzigold vyzigold commented Jan 30, 2024

This adds the needed variables for the observabilityclient to work. Observabilityclient allows to execute openstack metric command for interacting with prometheus deployed as part of telemetry MetricStorage by the telemetry-operator.

I should note that the observabilityclient currently isn't available in the openstackclient container image, so the openstack metric commands aren't available at the moment without manually installing it. But the PR itself doesn't require observabilityclient installed on the container.

Depends-On: #641

@vyzigold
Copy link
Contributor Author

Work on readding observabilityclient to the image is ongoing here: openstack-k8s-operators/tcib#122

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/965b7a22e8ca443faf729ee8017db007

openstack-k8s-operators-content-provider FAILURE in 12m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@vyzigold
Copy link
Contributor Author

I think the issue might be, that the added telemetry-operator dependency is too new and the operators in go.mod need to be updated first. I added a depends-on on that PR. I'll take a look at this once that's merged.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/af9a772b5ace4ae9804bd25f9549b741

openstack-k8s-operators-content-provider FAILURE in 13m 19s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@jlarriba
Copy link
Contributor

jlarriba commented Feb 6, 2024

/lgtm

@jlarriba jlarriba requested a review from abays February 6, 2024 08:46
hack/pin-bundle-images.sh Outdated Show resolved Hide resolved
@vyzigold
Copy link
Contributor Author

vyzigold commented Feb 7, 2024

I rebased on top of main

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/31fc2a45998f45c087494b5f337f006f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 55s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 12m 10s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 01s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 11m 47s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 57s

@vyzigold
Copy link
Contributor Author

vyzigold commented Feb 7, 2024

recheck

Failed to add subports to trunk 'f738f107-af28-4a9f-a0c0-773c84b5392f': ConflictException: 409: Client Error for url: https://network.rdo.mtl2.vexxhost.net/v2.0/trunks/f738f107-af28-4a9f-a0c0-773c84b5392f/add_subports, Port 91b881f3-dce8-44c8-b5fc-fa43db8f9083 is in use by another trunk.
ConflictException: 409: Client Error for url: https://compute.rdo.mtl2.vexxhost.net/v2.1/servers/4f95266a-ae23-4449-b865-04ab0b1c68b1/os-interface, Port 512b2651-37b3-4009-b5b4-c3df39d5b916 is still in use.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/037b28903b28413ca2ca5860a43439fb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 36s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 42s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 04m 51s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 21m 40s

@vyzigold
Copy link
Contributor Author

vyzigold commented Feb 7, 2024

recheck

ERROR! Unexpected Exception, this is probably a bug: [Errno 117] Structure needs cleaning: 'refs'

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4e8523b0418e4053b3a7e1e2989407cd

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 04m 49s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 1m 54s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 06m 38s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 52s

@vyzigold
Copy link
Contributor Author

recheck

1 similar comment
@vyzigold
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a6304f875c7646eabab0cf9524456331

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 50m 45s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 55m 00s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 44m 08s
openstack-operator-tempest-multinode FAILURE in 1h 05m 38s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e9ab743407754bd6a51424c1e5d00d49

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 22s
cifmw-crc-podified-edpm-baremetal FAILURE in 28m 04s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 11m 05s
openstack-operator-tempest-multinode FAILURE in 1h 24m 19s

@vyzigold
Copy link
Contributor Author

recheck
Different tempest scenarios failed this time:

tempest.scenario.test_server_volume_attachment.TestServerVolumeAttachScenarioOldVersion
tempest.scenario.test_server_volume_attachment.TestServerVolumeAttachmentScenario

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9396756e4e3048bea1284185b19c8c03

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 03m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 43s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 08m 54s
openstack-operator-tempest-multinode FAILURE in 1h 23m 40s

@vyzigold
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1bf7e2237071466aacabd1a725365a7e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 09m 05s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 11m 23s
openstack-operator-tempest-multinode FAILURE in 1h 17m 32s

@vyzigold
Copy link
Contributor Author

I squashed the commits, rebased on top of main and used the latest telemetry-operator api. This allowed me to drop the dependency on the telemetry-operator.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1f37ab3c04f64ebbb57c3c1319136449

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 43s
podified-multinode-edpm-deployment-crc FAILURE in 59m 43s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 02m 20s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 05m 05s
openstack-operator-tempest-multinode FAILURE in 1h 02m 49s

@vyzigold
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/455e7f60a7a54326b8b7e3d509a82211

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 14s
podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 30s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 06m 30s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 06m 34s
openstack-operator-tempest-multinode FAILURE in 1h 08m 05s

@vyzigold
Copy link
Contributor Author

recheck
memchached is trying to use an non-existing image. I saw some tests succeed this morning, so I hope the issue is fixed.

  Normal   Pulling         30m (x4 over 31m)    kubelet            Pulling image "quay.io/podified-antelope-centos9/openstack-memcached@sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582"
  Warning  Failed          30m (x4 over 31m)    kubelet            Failed to pull image "quay.io/podified-antelope-centos9/openstack-memcached@sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582": rpc error: code = Unknown desc = reading manifest sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582 in quay.io/podified-antelope-centos9/openstack-memcached: manifest unknown
  Warning  Failed          30m (x4 over 31m)    kubelet            Error: ErrImagePull
  Warning  Failed          29m (x6 over 31m)    kubelet            Error: ImagePullBackOff

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/762ee317f32745e3aa9a9c1b8912b4cf

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 26s
podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 07s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 04m 42s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 04m 17s
openstack-operator-tempest-multinode FAILURE in 1h 03m 41s

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 643,54aa7fab8055a388db92b300f90467c36043d186

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, jlarriba, vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants