Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS file to be more granular #2468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lewisdenny
Copy link
Collaborator

@lewisdenny lewisdenny commented Oct 21, 2024

By using OWNERS_ALIASES we can have teams own there own roles by adding
an OWNERS file into the directory. This patch starts by allowing two
shiftstack members to review patches that are in roles/shiftstack/**


Todo:

  • Find a home for the missing users

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lewisdenny. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/68e234d03c244bf0bb6eabe9b3cb82e4

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 25s
cifmw-pod-pre-commit FAILURE in 7m 38s
✔️ build-push-container-cifmw-client SUCCESS in 36m 52s

By using OWNERS_ALIASES we can have teams own there own roles by adding
an OWNERS file into the directory. This patch starts by allowing two
shiftstack members to review patches that are in roles/shiftstack/**
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openstack-k8s-operators org. You can then trigger verification by writing /verify-owners in a comment.

  • rlobillo
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@lewisdenny lewisdenny changed the title Add CODEOWNERS file to repo Update OWNERS file to be more granular Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant