[OSASINFRA] Add multi test configs support #1980
Conversation
|
Skipping CI for Draft Pull Request. |
eurijon
force-pushed
the
multi-testconfig
branch
from
0f97882
to
92b472f
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/223d6be507864fecaae83c44f29db6c7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 19s |
eurijon
force-pushed
the
multi-testconfig
branch
from
92b472f
to
56d30d4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3f72ec8cc5514096bbc78f3bef74709d ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 41s |
eurijon
force-pushed
the
multi-testconfig
branch
from
56d30d4
to
0119758
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c281ac2afa4d47c49ae965d1f0cb1901 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 50s |
eurijon
force-pushed
the
multi-testconfig
branch
from
0119758
to
9914038
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4e8e654f55264e2387df71174609ddab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 58s |
eurijon
force-pushed
the
multi-testconfig
branch
from
9914038
to
4333bc2
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac51c74494a345738aa11abd175f8868 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 56s |
eurijon
force-pushed
the
multi-testconfig
branch
from
4333bc2
to
cdb3ed4
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
eurijon
force-pushed
the
multi-testconfig
branch
from
cdb3ed4
to
3712521
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2c73f25a3ffa43c0bd84c2c44fb2bbab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 55s |
eurijon
force-pushed
the
multi-testconfig
branch
3 times, most recently
from
17282f8
to
a22dc75
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/79bf3ab7f05041bfbfb335f1b66de41c ❌ openstack-k8s-operators-content-provider FAILURE in 6m 24s |
eurijon
force-pushed
the
multi-testconfig
branch
from
a22dc75
to
d56bddd
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f067a5a3ad634c319fae9a5693f4d864 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 06s |
eurijon
force-pushed
the
multi-testconfig
branch
2 times, most recently
from
ceb179d
to
59a7ee4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a8064be99ccc4980a77ddd0e73793d86 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 01s |
eurijon
force-pushed
the
multi-testconfig
branch
2 times, most recently
from
eed7a4e
to
c7794cb
Compare
eurijon
force-pushed
the
multi-testconfig
branch
from
7e99f04
to
29a0347
Compare
|
@lewisdenny thanks for the review, I'm sorry I just added a minor change (appended the loop index to the test config artifacts file name) Do you think we can add @rlobillo as reviewer for the shiftstack role? |
Yes this is something we would like to enable. |
|
eurijon
force-pushed
the
multi-testconfig
branch
from
29a0347
to
6091b10
Compare
eurijon
force-pushed
the
multi-testconfig
branch
from
6091b10
to
241ca78
Compare
@rlobillo has been added to the github org now :) |
| @@ -21,13 +21,13 @@ | |||
| PATH: "{{ cifmw_path }}" | |||
| KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}" | |||
| ansible.builtin.command: | |||
| cmd: "oc rsh -n {{ namespace }} {{ pod }} bash -c '{{ command }}'" | |||
| register: command_result | |||
| cmd: "oc rsh -n {{ namespace }} {{ pod_name }} bash -c '{{ command }}'" | |||
There was a problem hiding this comment.
Command/Shell injection.... This is word a bug in Jira.
There was a problem hiding this comment.
We decided to go with this as we need to run ansible from the pod (another inventory, hosts and so on) and we didn't want to change ci-framework every time we do some change in our automation repo (shiftstack-qa).
In any case I'm open to discuss alternatives to the command injection.
Support multiple test configs or job definitions from the calling
zuul job, i.e:
cifmw_run_test_shiftstack_testconfig:
- 4.17_ovnkubernetes_ipi.yaml
- 4.17_ovnkubernetes_upi.yaml
- 4.17_ovnkubernetes_ipi-proxy.yaml
The shiftstack role will run the shiftstack-qa automation for
each test config defined in `cifmw_run_test_shiftstack_testconfig`.
The artifacts directory includes now an additional directory for
each test config, as multiple test configs can run now from a
Zuul job.
This commit adds the `cifmw_shiftstack_manifests_dir` param as
well for the role generated manifest files and the
`cifmw_shiftstack_ansible_command_logs_dir` param for the
ansible command module output logs.
eurijon
force-pushed
the
multi-testconfig
branch
from
241ca78
to
865e0e2
Compare
|
Adding back @pablintino lgtm, thanks for changing to assert, much nicer. /lgtm |
openshift-merge-bot
bot
merged commit cf200c7
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr1 |
|
@eurijon: new pull request created: #2488 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Support multiple test configs or job definitions from the calling zuul job, i.e:
The shiftstack role will run the shiftstack-qa automation for each test config defined in
cifmw_run_test_shiftstack_testconfig.The artifacts directory includes now an additional directory for each test config, as multiple test configs can run now from a Zuul job.
This commit adds the
cifmw_shiftstack_manifests_dirparam as well for the role generated manifest files and thecifmw_shiftstack_ansible_command_logs_dirparam for the ansible command module output logs.As a pull request owner and reviewers, I checked that: