Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new annotations to CSV #398

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Apr 8, 2024

- Description of the problem which is fixed/What is the use case

This replays #389 on devel.

- What I did

git cherry-pick be8fa65d3eb77f59c794ad19cdf0c085f8dc70ca and fixed trivial context conflict.

- How to verify it

  • Checkout this PR
  • Same change as be8fa65

- Description for the changelog

Fixes: KATA-2895

@openshift-ci openshift-ci bot requested review from jensfr and pmores April 8, 2024 22:01
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The `features.operators.openshift.io` infrastructure feature annotations,
introduced in OpenShift Container Platform 4.14, deprecate the
`operators.openshift.io/infrastructure-features` annotations used in
earlier versions of OpenShift Container Platform. See [1]

Drop the `operators.openshift.io/infrastructure-features` line.

[1] https://docs.openshift.com/container-platform/4.14/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations-deprecated_osdk-generating-csvs

Fixes: KATA-2895

Signed-off-by: Cameron Meadors <cmeadors@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
@gkurz gkurz force-pushed the replay-389-on-devel branch from 9659242 to 0208616 Compare April 9, 2024 15:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link

openshift-ci bot commented Apr 9, 2024

New changes are detected. LGTM label has been removed.

@gkurz
Copy link
Member Author

gkurz commented Apr 9, 2024

Point to the jira for upstream.

@gkurz gkurz merged commit af9c0b4 into openshift:devel Apr 9, 2024
2 of 4 checks passed
Copy link

openshift-ci bot commented Apr 9, 2024

@gkurz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 0208616 link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gkurz gkurz mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants