-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new annotations to CSV #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The `features.operators.openshift.io` infrastructure feature annotations, introduced in OpenShift Container Platform 4.14, deprecate the `operators.openshift.io/infrastructure-features` annotations used in earlier versions of OpenShift Container Platform. See [1] Drop the `operators.openshift.io/infrastructure-features` line. [1] https://docs.openshift.com/container-platform/4.14/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations-deprecated_osdk-generating-csvs Fixes: KATA-2895 Signed-off-by: Cameron Meadors <cmeadors@redhat.com> Signed-off-by: Greg Kurz <groug@kaod.org>
9659242
to
0208616
Compare
New changes are detected. LGTM label has been removed. |
Point to the jira for upstream. |
@gkurz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- Description of the problem which is fixed/What is the use case
This replays #389 on devel.
- What I did
git cherry-pick be8fa65d3eb77f59c794ad19cdf0c085f8dc70ca
and fixed trivial context conflict.- How to verify it
- Description for the changelog
Fixes: KATA-2895