KATA-2881: add new annotations to CSV #389
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@cpmeadors: This pull request references KATA-2881 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -13,6 +13,13 @@ metadata: | |||
| } | |||
| ] | |||
| capabilities: Seamless Upgrades | |||
| features.operators.openshift.io/disconnected: "true" | |||
| features.operators.openshift.io/fips-compliant: "false" | |||
There was a problem hiding this comment.
nit: this should be true given
operators.openshift.io/infrastructure-features: '["disconnected", "fips"]'
There was a problem hiding this comment.
ProdSec invalidated our FIPS compliance by invalidating anything based On UBI builds. We must build on rhel-els base images for FIPS compliance now. I wasn't sure what to do here. This pr is about resolving the CVP issues and it doesn't care what value is set, just that it is set. I think it would be clearer if we create additional stories to resolve the FIPS compliance issue.
There was a problem hiding this comment.
Is our FIPS compliance mentioned anywhere in the documentation ?
config/manifests/bases/sandboxed-containers-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
gkurz
force-pushed
the
add-new-feature-annotation
branch
from
ccc54a7 to
18ea38a
Compare
|
New changes are detected. LGTM label has been removed. |
|
@cpmeadors: This pull request references KATA-2881 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The `features.operators.openshift.io` infrastructure feature annotations, introduced in OpenShift Container Platform 4.14, deprecate the `operators.openshift.io/infrastructure-features` annotations used in earlier versions of OpenShift Container Platform. See [1] Drop the `operators.openshift.io/infrastructure-features` line. [1] https://docs.openshift.com/container-platform/4.14/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations-deprecated_osdk-generating-csvs Signed-off-by: Cameron Meadors <cmeadors@redhat.com> Signed-off-by: Greg Kurz <groug@kaod.org>
gkurz
force-pushed
the
add-new-feature-annotation
branch
from
18ea38a to
be8fa65
Compare
|
@cpmeadors: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This brings CSV fixes from openshift#389 and openshift#391, that we do want in devel. This also brings openshift#388 that we *do not* want since it removes all the 1.6.0 code from devel. This is addressed by a subsequent commit.
- Description of the problem which is fixed/What is the use case
CVP downstream requires new annotations to exist in the CSV. https://docs.openshift.com/container-platform/4.15/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-infra_osdk-generating-csvs
Closes: KATA-2881
- What I did
Added the annotations to CSV. I set disconnected to true and all the rest false. We can update them if that is wrong, but this should satisfy CVP.
- How to verify it
Make bundle. Check bundle/manifests/sandboxed-containers-operator.clusterserviceversion.yaml to see if new annotations are in rendered CSV
- Description for the changelog