Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeded jobs #4968

Merged
merged 1 commit into from
Sep 9, 2019
Merged

remove unneeded jobs #4968

merged 1 commit into from
Sep 9, 2019

Conversation

baude
Copy link
Contributor

@baude baude commented Sep 9, 2019

we no longer need to lint and validate with separate jobs as they are
being done on the CI itself.

Signed-off-by: baude bbaude@redhat.com

@baude
remove unneeded jobs
0de8b5c 
we no longer need to lint and validate with separate jobs as they are
being done on the CI itself.

Signed-off-by: baude <bbaude@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2019
@baude baude mentioned this pull request Sep 9, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2019
stevekuznetsov
stevekuznetsov reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4789325 into openshift:master Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

@baude: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key containers-libpod-master.yaml using file ci-operator/config/containers/libpod/containers-libpod-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key containers-libpod-master.yaml using file ci-operator/config/containers/libpod/containers-libpod-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key containers-libpod-master-presubmits.yaml using file ci-operator/jobs/containers/libpod/containers-libpod-master-presubmits.yaml

In response to this:

we no longer need to lint and validate with separate jobs as they are
being done on the CI itself.

Signed-off-by: baude bbaude@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baude @openshift-ci-robot @stevekuznetsov @openshift-merge-robot