Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lint and manpage check to make validate #3973

Merged
merged 1 commit into from
Sep 11, 2019
Merged

add lint and manpage check to make validate #3973

merged 1 commit into from
Sep 11, 2019

Conversation

baude
Copy link
Member

@baude baude commented Sep 9, 2019

make validate now runs golangci-lint and the man-page-checker to ensure
a PR is ready for our CI.

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Sep 9, 2019
@openshift-ci-robot
Copy link
Collaborator

@baude: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/validate f863210 link /test validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baude
Copy link
Member Author

baude commented Sep 9, 2019

requires -> openshift/release#4968

@baude
Copy link
Member Author

baude commented Sep 9, 2019

/retest

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2019

@edsantiago @mheon @giuseppe @vrothberg @TomSweeneyRedHat @QiWang19 @jwhonce PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tetss

edsantiago
edsantiago approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one minor question

.cirrus.yml Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member

Um one more question: is make validate something that a regular dev would ever run in their environment? If so, are devs required to have golangci-lint installed? Because now it's a hard requirement.

@baude
Copy link
Member Author

baude commented Sep 9, 2019

yeah it is basically now a requirement that you lint prior to submission unless of course you write perfect code? that doesnt apply to me

@baude
add lint and manpage check to make validate
ba7e863 
make validate now runs golangci-lint and the man-page-checker to ensure
a PR is ready for our CI system.

Signed-off-by: baude <bbaude@redhat.com>
vrothberg
vrothberg reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit f73c3b8 into containers:master Sep 11, 2019
@baude baude deleted the validateupdate branch December 22, 2019 19:14
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@edsantiago edsantiago edsantiago approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@baude @openshift-ci-robot @rhatdan @TomSweeneyRedHat @edsantiago @vrothberg @mheon @openshift-merge-robot