Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WALinuxAgent-udev package #824

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Add WALinuxAgent-udev package #824

merged 1 commit into from
Jun 8, 2022

Conversation

HuijingHei
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from jlebon and saqibali-2k June 7, 2022 03:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@HuijingHei
Copy link
Contributor Author

/retest

travier
travier reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit.

@HuijingHei HuijingHei force-pushed the add_azure_udev_rpm branch from 8e94db4 to debafcb Compare June 7, 2022 08:29
@travier
Copy link
Member

travier commented Jun 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@travier
Copy link
Member

travier commented Jun 7, 2022

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 939d8c8 and 8 for PR HEAD debafcb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 939d8c8 and 7 for PR HEAD debafcb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 939d8c8 and 6 for PR HEAD debafcb in total

@saqibali-2k
Copy link
Contributor

/lgtm

@saqibali-2k
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 21ea273 and 5 for PR HEAD debafcb in total

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

I tested this locally (cosa kola run -j3) and confirmed the udev rules are in the initrd:

$ lsinitrd /boot/ostree/rhcos-3b43b4bc294c0e0d95638458a9ce14836bf4b4d2a1106f632b786037b41a63a5/initramfs-4.18.0-372.9.1.el8.x86_64.img | grep azure
rhcos-azure-udev                                                                                                                                               
-rw-r--r--   1 root     root         1829 Jan  1  1970 usr/lib/udev/rules.d/66-azure-storage.rules                                                             
-rw-r--r--   1 root     root          343 Jan  1  1970 usr/lib/udev/rules.d/99-azure-product-uuid.rules

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, miabbott, saqibali-2k, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,miabbott,saqibali-2k,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

I believe we'll need to cherry-pick this to release-4.11 too

@cgwalters
Copy link
Member

/override ci/prow/test-in-cluster

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/test-in-cluster

In response to this:

/override ci/prow/test-in-cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit 662a11d into openshift:master Jun 8, 2022
@cgwalters
Copy link
Member

(General reminder until #829 lands let's just ignore test-in-cluster)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuijingHei HuijingHei deleted the add_azure_udev_rpm branch June 9, 2022 02:15
@HuijingHei
Copy link
Contributor Author

/cherrypick release-4.11

@openshift-cherrypick-robot
Copy link

@HuijingHei: new pull request created: #836

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqibali-2k saqibali-2k saqibali-2k approved these changes

@travier travier travier approved these changes

@jlebon jlebon Awaiting requested review from jlebon

Assignees

@miabbott miabbott

@saqibali-2k saqibali-2k

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RHCOS 4.11 + RHEL 8.6 - failing to install Azure udev rules in dracut
7 participants
@HuijingHei @travier @openshift-ci-robot @saqibali-2k @miabbott @cgwalters @openshift-cherrypick-robot