Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-in-cluster broken by https://github.com/coreos/coreos-layering-examples/pull/20 #829

Closed
cgwalters opened this issue Jun 7, 2022 · 3 comments · Fixed by coreos/layering-examples#26
Closed

test-in-cluster broken by https://github.com/coreos/coreos-layering-examples/pull/20 #829

cgwalters opened this issue Jun 7, 2022 · 3 comments · Fixed by coreos/layering-examples#26

Comments

@cgwalters
Copy link
Member

I should have realized this earlier but basically coreos/layering-examples#20 broke test-in-cluster because:

  • Suddenly we have multiple Dockerfile, not just one
  • Most of the Dockerfile require a rhel.repo

So...two things too:
@cgwalters
Copy link
Member Author

cc @cheesesashimi per our chat

@cheesesashimi
Copy link
Member

Fixing the multiple Dockerfile issue should be straightforward: https://github.com/openshift/os/blob/master/tests/layering/build_helper_test.go#L106-L109.

@cgwalters cgwalters mentioned this issue Jun 8, 2022
Merged
cgwalters added a commit to cgwalters/coreos-layering-examples that referenced this issue Jun 8, 2022
@cgwalters
generate-rhcos-versions: Only inject ADD rhel.repo if needed
2cd0da5 
Only some of the examples actually install packages, not all.
In particular the `selinux` one does not, and I want to use it
as a test case to fix openshift/os#829

I'm thinking actually we should drop this bit entirely and rely
on host subscriptions *or* users doing it on their own, but
for now this works.
@cgwalters cgwalters mentioned this issue Jun 8, 2022
Merged
@cgwalters
Copy link
Member Author

coreos/layering-examples#26 will help with this.

@cgwalters cgwalters mentioned this issue Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

generate-rhcos-versions: Only inject ADD rhel.repo if needed cgwalters/coreos-layering-examples
2 participants
@cgwalters @cheesesashimi