Update web console config #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/retest |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
This was referenced Jan 15, 2018
Closed
deads2k
reviewed
Jan 15, 2018
| for i, scriptURL := range config.ExtensionScripts { | ||
| if _, scriptURLErrs := ValidateSecureURL(scriptURL, fldPath.Child("extensionScripts").Index(i)); len(scriptURLErrs) > 0 { | ||
| if len(config.LogoutPublicURL) > 0 { | ||
| _, urlErrs := ValidateURL(config.LogoutPublicURL, fldPath.Child("logoutPublicURL")) |
There was a problem hiding this comment.
why isn't this required to be secure?
There was a problem hiding this comment.
Does it need to be? As I understand it, it is just a redirect URL after logout.
FWIW, it wasn't required to be secure before.
There was a problem hiding this comment.
Does it need to be?
I like all things secure. If it wasn't before, I guess it doesn't have to be today.
|
one question. lgtm otherwise |
|
/lgtm |
This was referenced Jan 16, 2018
|
origin and openshift-ansible changes have merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Jan 21, 2018
Automatic merge from submit-queue. Remove obsolete properties from console config map Stop writing deprecated config to the console config map. /hold This can't be merged until openshift/origin-web-console-server#20 merges. Follow on to #6730
mjudeikis
pushed a commit
to mjudeikis/openshift-ansible
that referenced
this pull request
Jan 22, 2018
…nfig Automatic merge from submit-queue. Remove obsolete properties from console config map Stop writing deprecated config to the console config map. /hold This can't be merged until openshift/origin-web-console-server#20 merges. Follow on to openshift#6730
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Jan 25, 2018
…onfig Automatic merge from submit-queue (batch tested with PRs 18191, 18264, 18235, 18251, 18271). cluster up: remove obsolete asset config properties Follow on to #18114 Requires openshift/origin-web-console-server#20 /assign @deads2k @jwforres @sdodson FYI /hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt API changes from openshift/api#31
Requires openshift/origin#18114
Requires openshift/openshift-ansible#6730
Replaces #19
/assign @deads2k
@jwforres FYI