Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update console config for API changes #6730

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Update console config for API changes #6730

merged 1 commit into from
Jan 17, 2018

Conversation

spadgett
Copy link
Member

Adopt API changes from openshift/api#31

For now, both the new and old config need to be written to avoid breaking install until origin-web-console-server is updated.

/assign @sdodson
@deads2k @jwforres FYI

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2018
@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2018

Right idea. Let me know when it is ready for review.

@spadgett spadgett force-pushed the console-config-api-changes branch from b8a9261 to 3d70abd Compare January 15, 2018 16:13
@spadgett
Copy link
Member Author

Corresponding origin changes: openshift/origin#18114

@spadgett spadgett mentioned this pull request Jan 15, 2018
Merged
@spadgett spadgett force-pushed the console-config-api-changes branch from 3d70abd to 0da4a17 Compare January 15, 2018 19:20
@spadgett spadgett changed the title [WIP] Update console config for API changes Update console config for API changes Jan 15, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2018
@spadgett
Copy link
Member Author

I was able to test with the changes from openshift/origin-web-console-server#20

@sdodson @deads2k this should be ready for a review

@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2018

The config file lgtm.

@spadgett
Copy link
Member Author

/retest

@spadgett spadgett force-pushed the console-config-api-changes branch from 0da4a17 to cbe2baa Compare January 16, 2018 15:39
@spadgett
Copy link
Member Author

Rebased

@spadgett
Copy link
Member Author

/retest

@sdodson
Copy link
Member

sdodson commented Jan 16, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2018
@spadgett spadgett force-pushed the console-config-api-changes branch from cbe2baa to cfcfe98 Compare January 16, 2018 21:10
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2018
@spadgett spadgett force-pushed the console-config-api-changes branch from cfcfe98 to b498f10 Compare January 16, 2018 21:16
@spadgett
Copy link
Member Author

@sdodson updated

@sdodson
Copy link
Member

sdodson commented Jan 16, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2018
@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@sdodson sdodson merged commit d5241bd into openshift:master Jan 17, 2018
@sdodson
Copy link
Member

sdodson commented Jan 17, 2018

It's waiting on travis but travis is backlogged according to their status page. Haven't seen a travis job post in ~5hrs.

@openshift-ci-robot
Copy link

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio b498f10 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett deleted the console-config-api-changes branch January 17, 2018 13:49
@spadgett spadgett mentioned this pull request Jan 17, 2018
Merged
openshift-merge-robot added a commit that referenced this pull request Jan 21, 2018
@openshift-merge-robot
Merge pull request #6754 from spadgett/remove-old-console-config
b1f728d 
Automatic merge from submit-queue.

Remove obsolete properties from console config map

Stop writing deprecated config to the console config map.

/hold

This can't be merged until openshift/origin-web-console-server#20 merges.
Follow on to #6730
mjudeikis pushed a commit to mjudeikis/openshift-ansible that referenced this pull request Jan 22, 2018
@openshift-merge-robot @mjudeikis
Merge pull request openshift#6754 from spadgett/remove-old-console-co…
b587c3f 
…nfig

Automatic merge from submit-queue.

Remove obsolete properties from console config map

Stop writing deprecated config to the console config map.

/hold

This can't be merged until openshift/origin-web-console-server#20 merges.
Follow on to openshift#6730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdodson sdodson

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spadgett @deads2k @sdodson @openshift-ci-robot @openshift-merge-robot