OCPBUGS-42106: Continuous pull-secret updates / slow initialization on build01 (test platform infrastructure)

[sanchezl]

A duplicate in the list of registry URLs will cause the controller to think that all image pull secrets needs to be refreshed. This PR de-duplicates the list of registry URLs to prevent that.

[openshift-ci-robot]

@sanchezl: This pull request references Jira Issue OCPBUGS-42106, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@sanchezl: This pull request references Jira Issue OCPBUGS-42106, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

A duplicate in the list of registry URLs will cause the controller to think that all image pull secrets needs to be refreshed. This PR de-duplicates the list of registry URLs to prevent that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[benluddy]

/lgtm

[adambkaplan]

/approve

Would love to see a unit test for this.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, benluddy, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adambkaplan]

/hold

Build suite is failing - need to figure out why

[adambkaplan]

Error pulling image "image-registry.openshift-image-registry.svc:5000/openshift/ruby:3.0-ubi8": initializing source docker://image-registry.openshift-image-registry.svc:5000/openshift/ruby:3.0-ubi8: reading manifest 3.0-ubi8 in image-registry.openshift-image-registry.svc:5000/openshift/ruby: manifest unknown

My hunch - the samples operator bump landed, and this imagestream doesn't exist anymore on new installs.

[openshift-ci]

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-builds	df3fa23	link	true	/test e2e-gcp-ovn-builds
ci/prow/e2e-gcp-ovn	df3fa23	link	true	/test e2e-gcp-ovn
ci/prow/openshift-e2e-aws-ovn-builds-techpreview	df3fa23	link	false	/test openshift-e2e-aws-ovn-builds-techpreview
ci/prow/security	df3fa23	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[adambkaplan]

Confirmed - sync for Samples Operator landed yesterday: openshift/cluster-samples-operator#569

[sanchezl]

/retest