OKD-225: Sync samples - OKD CI is completely broken currently due to removed containers #569
Conversation
|
/lgtm |
|
/test e2e-aws-ovn-image-ecosystem |
ausil
changed the title
|
/test e2e-aws-ovn-image-ecosystem |
ausil
changed the title
|
@ausil: This pull request references OKD-225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/cc @metlos |
|
|
|
The image streams are pulled from https://github.com/openshift/library during our release and we don't maintain a separate list of images/tags that should/shouldn't be pulled. I think this is more of a problem with the OpenShift library than with the samples operator. |
17530d2 commit lists a set of supported imagestreams which is why imagestreams like mariadb, SQL and redis have been dropped. Given that is the case, this PR is correct? It does sync whatever is supported. |
https://github.com/openshift/cluster-samples-operator/blob/master/library-sync.sh says that you do maintain a list of what is and is not synced. Ignoring and leaving in place old, unsupported content. Most of this PR comes from running that script. The second commit, removing old bits, comes from cleaning up stuff that is not updated by the script. |
|
/approve |
openshift-ci
bot
added
the
approved
Prashanth684
added
qe-approved
|
@ausil: This pull request references OKD-225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
can we override the |
1 similar comment
Sync the library to pull in the new version of nodejs and ruby templates Signed-off-by: Dennis Gilmore <dennis@ausil.us>
These unsupported imagestreams and not synced by the library-sync.sh and due to missing containers referenced from the repos the import is failing causing all CI to be breoken for OKD. so lets just remove them Signed-off-by: Dennis Gilmore <dennis@ausil.us>
Syncing rails due to a bump in library that hopefully fixes the CI breakage Signed-off-by: Dennis Gilmore <dennis@ausil.us>
|
/retest |
|
@metlos i appreciate that you are trying to fix the e2e ecosystem test, but could we please override that job to push these changes through as they will unblock OKD releases? we haven't had a green release image for over a week now. |
|
/override e2e-aws-ovn-image-ecosystem |
|
@metlos: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-image-ecosystem |
|
@metlos: Overrode contexts on behalf of metlos: ci/prow/e2e-aws-ovn-image-ecosystem In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ausil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, ausil, metlos, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-samples-operator |
remove unsupported imagestreams from OKD.
These unsupported imagestreams and not synced by the library-sync.sh and
due to missing containers referenced from the repos the import is
failing causing all CI to be broken for OKD. so lets just remove them