-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-22332: Bump openshift/api for custom-host permission error message #451
Conversation
Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5, which improves the error message when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without having the required "custom-host" permission. Instead of "field is immutable", the error message will have "you do not have permission". This does not change the HTTP status code for these errors. go get github.com/openshift/library-go@354b67330 go mod tidy go mod vendor This commit fixes OCPBUGS-22332. https://issues.redhat.com/browse/OCPBUGS-22332 * go.mod: Bump. * go.sum: * vendor/*: Regenerate.
@Miciah: This pull request references Jira Issue OCPBUGS-22332, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The verify job failed because the |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
/hold cancel |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/jira refresh |
@lihongan: This pull request references Jira Issue OCPBUGS-22332, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
I think we could close this one since it is superseded by #459 |
Correct. Thanks! /close |
@Miciah: This pull request references Jira Issue OCPBUGS-22332. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Miciah: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5, which improves the error message when the user tries to update a route's
spec.host
,spec.subdomain
, orspec.tls
field without having the required "custom-host" permission. Instead of "field is immutable", the error message will have "you do not have permission". This does not change the HTTP status code for these errors.This vendors the change in openshift/library-go#1677.