Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22332: Bump openshift/api for custom-host permission error message #451

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 26, 2024

Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5, which improves the error message when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without having the required "custom-host" permission. Instead of "field is immutable", the error message will have "you do not have permission". This does not change the HTTP status code for these errors.


This vendors the change in openshift/library-go#1677.

Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5,
which improves the error message when the user tries to update a route's
spec.host, spec.subdomain, or spec.tls field without having the required
"custom-host" permission.  Instead of "field is immutable", the error message
will have "you do not have permission".  This does not change the HTTP status
code for these errors.

    go get github.com/openshift/library-go@354b67330
    go mod tidy
    go mod vendor

This commit fixes OCPBUGS-22332.

https://issues.redhat.com/browse/OCPBUGS-22332

* go.mod: Bump.
* go.sum:
* vendor/*: Regenerate.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@Miciah: This pull request references Jira Issue OCPBUGS-22332, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5, which improves the error message when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without having the required "custom-host" permission. Instead of "field is immutable", the error message will have "you do not have permission". This does not change the HTTP status code for these errors.


This vendors the change in openshift/library-go#1677.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor Author

Miciah commented Sep 26, 2024

The verify job failed because the openapi-gen command in the update-generated-openapi.sh script failed with the error message unknown flag: --build-tag.

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify e52c293 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dinhxuanvu
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
@dinhxuanvu
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lihongan
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2024
@openshift-ci-robot
Copy link

@lihongan: This pull request references Jira Issue OCPBUGS-22332, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan November 25, 2024 01:55
@lihongan
Copy link

I think we could close this one since it is superseded by #459

@Miciah
Copy link
Contributor Author

Miciah commented Nov 26, 2024

I think we could close this one since it is superseded by #459

Correct. Thanks!

/close

@openshift-ci openshift-ci bot closed this Nov 26, 2024
@openshift-ci-robot
Copy link

@Miciah: This pull request references Jira Issue OCPBUGS-22332. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bump to github.com/openshift/library-go@354b673304be747827a7873426952da68f96b5c5, which improves the error message when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without having the required "custom-host" permission. Instead of "field is immutable", the error message will have "you do not have permission". This does not change the HTTP status code for these errors.


This vendors the change in openshift/library-go#1677.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@Miciah: Closed this PR.

In response to this:

I think we could close this one since it is superseded by #459

Correct. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants