OCPBUGS-22332: route: Improve errors for missing custom-host permissions

[Miciah]

Return "you do not have permission" error messages instead of "field is immutable" error messages when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without the required "custom-host" permission.

Note that this change does not affect the HTTP status code for these errors, which will continue to be HTTP 422, "Unprocessable Entity", as both the openshift-apiserver admission and the kube-apiserver admission wrap errors from the route validation's ValidateHostUpdate function using "k8s.io/apimachinery/pkg/api/errors".NewInvalid.

• pkg/route/hostassignment/assignment.go (routeHostPermissionErrMsg, routeSubdomainPermissionErrMsg, routeTLSPermissionErrMsg): New consts.
  (AllocateHost): Use routeHostPermissionErrMsg and routeTLSPermissionErrMsg instead of string literals.
  (validateImmutableField): New helper function, based on ValidateImmutableField from apimachinery but using a custom error message.
  (ValidateHostUpdate): Use the new consts and helper function instead of ValidateImmutableField from apimachinery.

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-22332, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Return "you do not have permission" error messages instead of "field is immutable" error messages when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without the required "custom-host" permission.

Note that this change does not affect the HTTP status code for these errors, which will continue to be HTTP 422, "Unprocessable Entity", as both the openshift-apiserver admission and the kube-apiserver admission wrap errors from the route validation's ValidateHostUpdate function using "k8s.io/apimachinery/pkg/api/errors".NewInvalid.

• pkg/route/hostassignment/assignment.go (routeHostPermissionErrMsg, routeSubdomainPermissionErrMsg, routeTLSPermissionErrMsg): New consts.
  (AllocateHost): Use routeHostPermissionErrMsg and routeTLSPermissionErrMsg instead of string literals.
  (validateImmutableField): New helper function, based on ValidateImmutableField from apimachinery but using a custom error message.
  (ValidateHostUpdate): Use the new consts and helper function instead of ValidateImmutableField from apimachinery.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Miciah]

https://github.com/openshift/library-go/compare/0c62e2597c52a1093f3a42a4e729f11dd453a304..46855ec7e21d0f7014518272b1f165e6c2ae04ed rebases for changes in #1625.

[candita]

/assign @gcs278
/assign @alebedev87

[Miciah]

/jira refresh

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-22332, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

Reviewed. Usually I like to test out PRs that I review, but since this also needs vendoring elsewhere, I'll just provide LGTM based on my assessment that the code updates are only impacting error messages, which feels low-risk to me.
/lgtm

/hold
@alebedev87 did you want a quick review? Let's give 1 more week, but if you don't have time, let's send this through as it's low risk.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/route/OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alebedev87]

LGTM
/unhold

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@Miciah: Jira Issue OCPBUGS-22332: All pull requests linked via external trackers have merged:

• openshift/library-go#1677

Jira Issue OCPBUGS-22332 has been moved to the MODIFIED state.

In response to this:

Return "you do not have permission" error messages instead of "field is immutable" error messages when the user tries to update a route's spec.host, spec.subdomain, or spec.tls field without the required "custom-host" permission.

Note that this change does not affect the HTTP status code for these errors, which will continue to be HTTP 422, "Unprocessable Entity", as both the openshift-apiserver admission and the kube-apiserver admission wrap errors from the route validation's ValidateHostUpdate function using "k8s.io/apimachinery/pkg/api/errors".NewInvalid.

• pkg/route/hostassignment/assignment.go (routeHostPermissionErrMsg, routeSubdomainPermissionErrMsg, routeTLSPermissionErrMsg): New consts.
  (AllocateHost): Use routeHostPermissionErrMsg and routeTLSPermissionErrMsg instead of string literals.
  (validateImmutableField): New helper function, based on ValidateImmutableField from apimachinery but using a custom error message.
  (ValidateHostUpdate): Use the new consts and helper function instead of ValidateImmutableField from apimachinery.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.