Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-24427: Allow setting overprovision ratio to 1 #520

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #518

/assign suleymanakbas91

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24396 has been cloned as Jira Issue OCPBUGS-24427. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-24427: Allow setting overprovision ratio to 1

In response to this:

This is an automated cherry-pick of #518

/assign suleymanakbas91

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-24396: Allow setting overprovision ratio to 1 [release-4.14] OCPBUGS-24427: Allow setting overprovision ratio to 1 Dec 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-24427, which is invalid:

  • expected dependent Jira Issue OCPBUGS-24396 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #518

/assign suleymanakbas91

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-4.14@a9b09ff). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release-4.14     #520   +/-   ##
===============================================
  Coverage                ?   17.39%           
===============================================
  Files                   ?       24           
  Lines                   ?     2087           
  Branches                ?        0           
===============================================
  Hits                    ?      363           
  Misses                  ?     1697           
  Partials                ?       27           

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@jakobmoellerdev
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@suleymanakbas91
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, openshift-cherrypick-robot, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 merged commit 5087a5d into openshift:release-4.14 Dec 5, 2023
5 of 6 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24427: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24427 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #518

/assign suleymanakbas91

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Author

@suleymanakbas91: #520 failed to apply on top of branch "release-4.13":

Applying: fix: allow setting overprovision ratio to 1
Using index info to reconstruct a base tree...
M	api/v1alpha1/lvmcluster_types.go
M	bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
M	bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
M	config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
M	config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
A	docs/design/thin-provisioning.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/design/thin-provisioning.md deleted in HEAD and modified in fix: allow setting overprovision ratio to 1. Version fix: allow setting overprovision ratio to 1 of docs/design/thin-provisioning.md left in tree.
Auto-merging config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
Auto-merging config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Auto-merging bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
Auto-merging bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
Auto-merging api/v1alpha1/lvmcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: allow setting overprovision ratio to 1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants