fix: allow setting overprovision ratio to 1

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
openshift · Dec 5, 2023 · b31b104 · b31b104
1 parent a9b09ff
commit b31b104
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/api/v1alpha1/lvmcluster_types.go b/api/v1alpha1/lvmcluster_types.go
@@ -52,7 +52,7 @@ type ThinPoolConfig struct {
 
 	// OverProvisionRatio is the factor by which additional storage can be provisioned compared to
 	// the available storage in the thin pool.
-	// +kubebuilder:validation:Minimum=2
+	// +kubebuilder:validation:Minimum=1
 	// +kubebuilder:validation:Required
 	// +required
 	OverprovisionRatio int `json:"overprovisionRatio"`

diff --git a/bundle/manifests/lvm.topolvm.io_lvmclusters.yaml b/bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
@@ -191,7 +191,7 @@ spec:
                               description: OverProvisionRatio is the factor by which
                                 additional storage can be provisioned compared to
                                 the available storage in the thin pool.
-                              minimum: 2
+                              minimum: 1
                               type: integer
                             sizePercent:
                               default: 90

diff --git a/bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml b/bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
@@ -151,7 +151,7 @@ spec:
                     description: OverProvisionRatio is the factor by which additional
                       storage can be provisioned compared to the available storage
                       in the thin pool.
-                    minimum: 2
+                    minimum: 1
                     type: integer
                   sizePercent:
                     default: 90

diff --git a/config/crd/bases/lvm.topolvm.io_lvmclusters.yaml b/config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
@@ -189,7 +189,7 @@ spec:
                               description: OverProvisionRatio is the factor by which
                                 additional storage can be provisioned compared to
                                 the available storage in the thin pool.
-                              minimum: 2
+                              minimum: 1
                               type: integer
                             sizePercent:
                               default: 90

diff --git a/config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml b/config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
@@ -153,7 +153,7 @@ spec:
                     description: OverProvisionRatio is the factor by which additional
                       storage can be provisioned compared to the available storage
                       in the thin pool.
-                    minimum: 2
+                    minimum: 1
                     type: integer
                   sizePercent:
                     default: 90

diff --git a/docs/design/thin-provisioning.md b/docs/design/thin-provisioning.md
@@ -46,7 +46,7 @@ The LVMS will create a thin pool LV in the Volume Group in order to create thinl
 
     +   // OverProvisionRatio represents the ratio of overprovision that can
     +   // be allowed on thin pools
-    +   // +kubebuilder:validation:Minimum=2
+    +   // +kubebuilder:validation:Minimum=1
     +   OverprovisionRatio int `json:"overprovisionRatio,omitempty"`
     }