-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network to api-resources we always fetch #785
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
At some point this should be made configurable, so the container doesn't always try to fetch this. e.g. for EKS or potentially Vanilla Kube (hint hint)
@JAORMX: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi Ozz, it’s good to hear from you! How are things going? That’s a good suggestion, thanks for the hints! |
the network resource helps us determine networkType of the platform we're running on. We add it to the list of resources we always fetch to be able to write a CPE that will verify if the cluster has OVN/SDN network type This PR works in conjunction with: ComplianceAsCode/content#8134
After we added OVN,SDN CPE from: ComplianceAsCode#8134, and openshift/compliance-operator#785 we will be able to addrees the issue where SDN rules was run on OVN cluster. This fix ensure the SDN rules will only run on SDN openshift clusters Relate BUGZILLA Link: https://bugzilla.redhat.com/show_bug.cgi?id=1994609
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, can you add a changelog blob? I'll merge the other PR so that yours doesn't conflict
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Vincent056: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
After we added OVN,SDN CPE from: ComplianceAsCode#8134, and openshift/compliance-operator#785 we will be able to addrees the issue where SDN rules was run on OVN cluster. This fix ensure the SDN rules will only run on SDN openshift clusters Relate BUGZILLA Link: https://bugzilla.redhat.com/show_bug.cgi?id=1994609
The network resource helps us determine the network type of the platform we're running on.
We add it to the list of resources we always fetch to be able to write a CPE that will verify if the cluster has an OVN/SDN network type
This PR works in conjunction with: ComplianceAsCode/content#8134