Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4 adds OVN,SDN networkType CPE #8134

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Jan 31, 2022

We want to add OVN and SDN network type CPE so that OVN/SDN rules can be run on the correct platform accordingly

This PR is also to address: https://bugzilla.redhat.com/show_bug.cgi?id=1994609

@Vincent056 Vincent056 changed the title OCP4 adds OVN,SDN networkType CPE WIP: OCP4 adds OVN,SDN networkType CPE Feb 1, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 1, 2022
@Vincent056 Vincent056 changed the title WIP: OCP4 adds OVN,SDN networkType CPE OCP4 adds OVN,SDN networkType CPE Feb 1, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 1, 2022
@Vincent056
Copy link
Contributor Author

/retest

1 similar comment
@JAORMX
Copy link
Contributor

JAORMX commented Feb 1, 2022

/retest

@Vincent056
Copy link
Contributor Author

/retest

1 similar comment
@Vincent056
Copy link
Contributor Author

/retest

We want to add OVN and SDN network type CPE so that OVN/SDN rules can be run on the correct platform

This PR is also to address: https://bugzilla.redhat.com/show_bug.cgi?id=1994609
@Vincent056
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@Vincent056: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 2d5efb2 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-ocp4-moderate-node 2d5efb2 link true /test e2e-aws-ocp4-moderate-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Vincent056 added a commit to Vincent056/cac-content-fork that referenced this pull request Feb 2, 2022
After we added OVN,SDN CPE from: ComplianceAsCode#8134, and openshift/compliance-operator#785 we will be able to addrees the issue where SDN rules was run on OVN cluster. This fix ensure the SDN rules will only run on SDN openshift clusters

Relate BUGZILLA Link: https://bugzilla.redhat.com/show_bug.cgi?id=1994609
Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhrozek
Copy link
Collaborator

jhrozek commented Feb 3, 2022

In tests, I see one cluster-up failure and the known IDP failure. Since this PR is about adding a new CPE, I think it's safe to merge.

@jhrozek jhrozek merged commit 9993d65 into ComplianceAsCode:master Feb 3, 2022
Vincent056 added a commit to Vincent056/cac-content-fork that referenced this pull request Feb 10, 2022
After we added OVN,SDN CPE from: ComplianceAsCode#8134, and openshift/compliance-operator#785 we will be able to addrees the issue where SDN rules was run on OVN cluster. This fix ensure the SDN rules will only run on SDN openshift clusters

Relate BUGZILLA Link: https://bugzilla.redhat.com/show_bug.cgi?id=1994609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants