-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1995386: don't return err in wait.Poll on net.DialTimeout err; tweak time intervals #386
Bug 1995386: don't return err in wait.Poll on net.DialTimeout err; tweak time intervals #386
Conversation
@gabemontero: This pull request references Bugzilla bug 1995386, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
more must gather failures after passing tests /retest |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
unrelated sig-cli and sig-apimachinery flakes in e2e-aws /test e2e-aws |
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
the okd-e2e-aws-builds only had a sig-arch flake unrelated to this PR ... all the sig-build tests passed going to /skip just so any retests don't bother with that one |
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 1995386 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @coreydaley
@dperaza4dustbit FYI - we missed something in code/review
also decided to bump retry slightly