Allow setting properties and root_device #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
requested changes
Mar 27, 2019
Due to limitations in terraform, we can't pass a nested map here so instead surface the root_device as a top-level interface, then set the map value internally. More info at hashicorp/terraform#2114 Fixes: openshift-metal3#8
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 28, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 28, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
stbenjam
approved these changes
Mar 28, 2019
Good point, I added it to utils.sh assuming that patch may land before the switch to kni-installer. Are you planning a rebase to the kni-installer patch, or should I post a follow-up? I guess we'll need to expose this via install-config for the baremetal platform as well. |
|
If this goes first I'll update the kni-installer PR's to include root_device |
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 28, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 29, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 29, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Mar 29, 2019
This is required for enabling extra disks, e.g for rook/ceph This also enables an extra disk so we can prove this works and support testing with ceph/rook. Note this requires openshift-metal3/terraform-provider-ironic#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8