Support for nested maps in variables #2114

nevir · 2015-05-28T01:00:40Z

I'd love to be able to do this:

variable "amis" {
  default = {
    app1 = {
      us-west-2 = "ami-abc123"
    }
    app2 = {
      us-west-2 = "ami-cba321"
    }
  }
}

Currently, you'd get an error like Variable 'amis': must be string or mapping

The text was updated successfully, but these errors were encountered:

nevir · 2015-05-28T01:03:48Z

Interestingly, I can cheat a bit:

variable "amis" {
  default = {
    app.us-west-2 = "ami-abc123"
    app2.us-west-2 = "ami-cba321"
  }
}

ghost · 2015-07-20T14:25:47Z

+1

bhouse · 2015-07-20T22:16:01Z

+1

ketzacoatl · 2015-07-21T16:19:08Z

+1, I didn't realize this was not possible.

jbiel · 2015-07-21T16:44:43Z

+1

ojongerius · 2015-07-24T06:52:33Z

+1

RBeaudoin · 2015-08-25T01:20:12Z

+1

spheromak · 2015-09-11T17:59:45Z

👍 really need to be able to pass data types other than strings in the DSL.

alexgervais · 2015-09-14T18:07:10Z

+1

sherabi · 2015-10-01T17:11:49Z

+1 really need this one

quater · 2015-10-06T10:31:01Z

+1

OleksandrBerchenko · 2015-10-28T14:44:58Z

+1

rodlogic · 2015-11-06T15:54:42Z

+1

Deserved · 2015-11-12T20:34:21Z

+1

ephemeral · 2015-12-08T20:57:55Z

+1

craigwatson · 2015-12-17T16:39:17Z

+1

bigkraig · 2016-02-01T22:49:44Z

Being able to have a list as a value would also be very nice

giorgioprevitera · 2016-03-20T12:53:35Z

+1

jare19 · 2016-04-06T15:49:00Z

👍

mblankleder · 2016-04-15T15:10:31Z

+1

vadanx · 2016-04-27T13:21:11Z

+1

ghost · 2016-05-05T00:56:27Z

+1

multiloc · 2016-05-19T09:42:04Z

+1

eedwardsdisco · 2016-05-22T18:33:14Z

+1

gogs2k · 2016-06-06T10:03:26Z

+1

JohnDzialo · 2016-06-23T20:08:48Z

+1

balooo · 2016-06-27T14:30:17Z

+1

mubeta06 · 2017-03-15T22:13:44Z

+1

sjauld · 2017-03-15T22:16:21Z

+1

jtsaito · 2017-03-16T09:15:27Z

+1

tomstockton · 2017-03-16T11:33:24Z

+1

What are people doing to work around this?

asciifaceman · 2017-03-16T17:39:59Z

@tomstockton it's been two years, had to drop terraform originally and then brought it back in a lesser capacity

hua3721 · 2017-03-17T05:53:17Z

Here is what I would do as an alternative for this map of map issue:

variable amis {
    app1 = "app1_map"
    app2 = "app2_map"
}
app1_map = {
      us-west-2 = "ami-abc123"
}
app2_map = {
      us-west-2 = "ami-cba321"
    }
}

sprutner · 2017-03-21T20:58:35Z

Here's what I did for multi-environment in one variables.tf file symlinked into each environment folder

variable "subnets" {
    type = "map"
    default = {
        dev             = "10.104.0.0/16"
        qa              = "10.103.0.0/16"
        stage           = "10.102.0.0/16"
        prod            = "10.101.0.0/16"
        app.dev         = "10.104.20.0/23"
        app.qa          = "10.103.20.0/23"
        app.stage       = "10.102.20.0/23"
        app.prod        = "10.101.20.0/23"
        app_1.dev       = "10.104.20.0/24"
        app_1.qa        = "10.103.20.0/24"
        app_1.stage     = "10.102.20.0/24"
        app_1.prod      = "10.101.20.0/24"
        app_2.dev       = "10.104.21.0/24"
        app_2.qa        = "10.103.21.0/24"
        app_2.stage     = "10.102.21.0/24"
        app_2.prod      = "10.101.21.0/24"
        public.dev      = "10.104.10.0/23"
        public.qa       = "10.103.10.0/23"
        public.stage    = "10.102.10.0/23"
        public.prod     = "10.101.10.0/23"
        public_1.dev    = "10.104.10.0/24"
        public_1.qa     = "10.103.10.0/24"
        public_1.stage  = "10.102.10.0/24"
        public_1.prod   = "10.101.10.0/24"
        public_2.dev    = "10.104.11.0/24"
        public_2.qa     = "10.103.11.0/24"
        public_2.stage  = "10.102.11.0/24"
        public_2.prod   = "10.101.11.0/24"
        private_1.dev   = "10.104.xx.0/24"
        private_1.qa    = "10.103.xx.0/24"
        private_1.stage = "10.102.xx.0/24"
        private_1.prod  = "10.101.xx.0/24"
        private_2.dev   = "10.104.xx.0/24"
        private_2.qa    = "10.103.xx.0/24"
        private_2.stage = "10.102.xx.0/24"
        private_2.prod  = "10.101.xx.0/24"
    }
}

and then call it like

module "vpc" {
  source = "../modules/aws_vpc/"

  # we call the environment 'variable' here for the vpc name

  name          = "vpc-${var.environment}"

  cidr                    = "${lookup(var.subnets, var.environment)}"
  private_subnets         = ["${lookup(var.subnets, "private_1.${var.environment}")}", "${lookup(var.subnets, "private_2.${var.environment}")}"]
  public_subnets          = ["${lookup(var.subnets, "public_1.${var.environment}")}", "${lookup(var.subnets, "public_2.${var.environment}")}"]
  app_subnets             = ["${lookup(var.subnets, "app_1.${var.environment}")}", "${lookup(var.subnets, "app_2.${var.environment}")}"]
  enable_dns_hostnames    = true
  enable_dns_support      = true
  enable_nat_gateway      = "true"
}

ghost · 2017-04-26T07:50:24Z

+1

mossy02 · 2017-05-05T17:47:51Z

+1

nilo · 2017-05-11T13:53:13Z

+1

apparentlymart · 2018-10-26T17:22:40Z

I just verified that the example given in the original comment on this issue works in Terraform v0.12-alpha1:

variable "amis" {
  default = {
    app1 = {
      us-west-2 = "ami-abc123"
    }
    app2 = {
      us-west-2 = "ami-cba321"
    }
  }
}

output "amis" {
  value = var.amis
}

In addition, Terraform v0.12 introduces the idea of object types which allow specification of variables that expect a specific set of attributes that may be of different types:

variable "regions" {
  type = map(map(object({
    ami = string
  })))

  default = {
    app1 = {
      us-west-2 = {
        ami = "ami-abc123"
      }
    }
    app2 = {
      us-west-2 = {
        ami = "ami-cba321"
      }
    }
  }
}

output "regions" {
  value = var.regions
}

Although there is still a remaining small issue to fix over in #19141, this feature request is now complete. Thanks for your patience, everyone!

Due to limitations in terraform, we can't pass a nested map here so instead surface the root_device as a top-level interface, then set the map value internally. More info at hashicorp/terraform#2114 Fixes: openshift-metal3#8

* Handle properties * Expose root_device as a top-level parameter Due to limitations in terraform, we can't pass a nested map here so instead surface the root_device as a top-level interface, then set the map value internally. More info at hashicorp/terraform#2114 Fixes: #8

arbreezy · 2019-07-30T10:39:44Z

Here's what I did for multi-environment in one variables.tf file symlinked into each environment folder

variable "subnets" {
    type = "map"
    default = {
        dev             = "10.104.0.0/16"
        qa              = "10.103.0.0/16"
        stage           = "10.102.0.0/16"
        prod            = "10.101.0.0/16"
        app.dev         = "10.104.20.0/23"
        app.qa          = "10.103.20.0/23"
        app.stage       = "10.102.20.0/23"
        app.prod        = "10.101.20.0/23"
        app_1.dev       = "10.104.20.0/24"
        app_1.qa        = "10.103.20.0/24"
        app_1.stage     = "10.102.20.0/24"
        app_1.prod      = "10.101.20.0/24"
        app_2.dev       = "10.104.21.0/24"
        app_2.qa        = "10.103.21.0/24"
        app_2.stage     = "10.102.21.0/24"
        app_2.prod      = "10.101.21.0/24"
        public.dev      = "10.104.10.0/23"
        public.qa       = "10.103.10.0/23"
        public.stage    = "10.102.10.0/23"
        public.prod     = "10.101.10.0/23"
        public_1.dev    = "10.104.10.0/24"
        public_1.qa     = "10.103.10.0/24"
        public_1.stage  = "10.102.10.0/24"
        public_1.prod   = "10.101.10.0/24"
        public_2.dev    = "10.104.11.0/24"
        public_2.qa     = "10.103.11.0/24"
        public_2.stage  = "10.102.11.0/24"
        public_2.prod   = "10.101.11.0/24"
        private_1.dev   = "10.104.xx.0/24"
        private_1.qa    = "10.103.xx.0/24"
        private_1.stage = "10.102.xx.0/24"
        private_1.prod  = "10.101.xx.0/24"
        private_2.dev   = "10.104.xx.0/24"
        private_2.qa    = "10.103.xx.0/24"
        private_2.stage = "10.102.xx.0/24"
        private_2.prod  = "10.101.xx.0/24"
    }
}

and then call it like

module "vpc" {
  source = "../modules/aws_vpc/"

  # we call the environment 'variable' here for the vpc name

  name          = "vpc-${var.environment}"

  cidr                    = "${lookup(var.subnets, var.environment)}"
  private_subnets         = ["${lookup(var.subnets, "private_1.${var.environment}")}", "${lookup(var.subnets, "private_2.${var.environment}")}"]
  public_subnets          = ["${lookup(var.subnets, "public_1.${var.environment}")}", "${lookup(var.subnets, "public_2.${var.environment}")}"]
  app_subnets             = ["${lookup(var.subnets, "app_1.${var.environment}")}", "${lookup(var.subnets, "app_2.${var.environment}")}"]
  enable_dns_hostnames    = true
  enable_dns_support      = true
  enable_nat_gateway      = "true"
}

FYI: Terraform v0.12 will complain about the ' . ' in the subnet variables (e.g app.dev) with this error:
Error: Ambiguous attribute key
I changed the ' . ' delimiter and works fine.

ghost · 2019-07-31T01:50:26Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

phinze added enhancement core labels May 30, 2015

apparentlymart mentioned this issue Nov 18, 2015

Wish list #3963

Closed

hashicorp locked and limited conversation to collaborators May 11, 2017

VAdamec mentioned this issue Jun 19, 2017

How to do nested iteration in Terraform oracle/terraform-provider-oci#86

Closed

xoen mentioned this issue May 16, 2018

Lambda Module ministryofjustice/analytics-platform-ops#139

Merged

facundovictor mentioned this issue May 16, 2018

core: Allow the use heterogeneous maps in module variables and outputs #14322

Closed

apparentlymart added config and removed core labels Aug 1, 2018

apparentlymart mentioned this issue Aug 1, 2018

Duplicate Keys in Maps Get De-Duplicated During Count #18573

Closed

hashicorp unlocked this conversation Oct 26, 2018

apparentlymart closed this as completed Oct 26, 2018

apparentlymart added this to the v0.12.0 milestone Oct 29, 2018

maxenglander mentioned this issue Jan 8, 2019

GH-233: initial commit adding support for ebs volumes in worker groups terraform-aws-modules/terraform-aws-eks#236

Closed

zeenix mentioned this issue Apr 3, 2019

Add storage pool resource dmacvicar/terraform-provider-libvirt#571

Merged

5 tasks

ghost locked and limited conversation to collaborators Jul 31, 2019

Support for nested maps in variables #2114

Support for nested maps in variables #2114

Comments

nevir commented May 28, 2015

nevir commented May 28, 2015

ghost commented Jul 20, 2015

bhouse commented Jul 20, 2015

ketzacoatl commented Jul 21, 2015

jbiel commented Jul 21, 2015

ojongerius commented Jul 24, 2015

RBeaudoin commented Aug 25, 2015

spheromak commented Sep 11, 2015

alexgervais commented Sep 14, 2015

sherabi commented Oct 1, 2015

quater commented Oct 6, 2015

OleksandrBerchenko commented Oct 28, 2015

rodlogic commented Nov 6, 2015

Deserved commented Nov 12, 2015

ephemeral commented Dec 8, 2015

craigwatson commented Dec 17, 2015

bigkraig commented Feb 1, 2016

giorgioprevitera commented Mar 20, 2016

jare19 commented Apr 6, 2016

mblankleder commented Apr 15, 2016

vadanx commented Apr 27, 2016

ghost commented May 5, 2016

multiloc commented May 19, 2016

eedwardsdisco commented May 22, 2016

gogs2k commented Jun 6, 2016

JohnDzialo commented Jun 23, 2016

balooo commented Jun 27, 2016

mubeta06 commented Mar 15, 2017

sjauld commented Mar 15, 2017

jtsaito commented Mar 16, 2017

tomstockton commented Mar 16, 2017

asciifaceman commented Mar 16, 2017

hua3721 commented Mar 17, 2017

sprutner commented Mar 21, 2017 • edited Loading

ghost commented Apr 26, 2017

mossy02 commented May 5, 2017

nilo commented May 11, 2017

apparentlymart commented Oct 26, 2018

arbreezy commented Jul 30, 2019

ghost commented Jul 31, 2019

sprutner commented Mar 21, 2017 •

edited

Loading