[RELEASE-1.15] Back-port upstream istio.sidecar.inject labels #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0ebef64)
bumping knative.dev/net-istio a9517c7...e6259b9: > e6259b9 upgrade to latest dependencies (# 1370) > 8d4a09e Use istio.sidecar.inject label instead of annotation (# 1369) > 34ed280 upgrade to latest dependencies (# 1368) Signed-off-by: Knative Automation <automation@knative.team> (cherry picked from commit 293d2bb)
|
We'll have to manually merge, cause of the Konflux enterprise-contract stuff |
|
/test ? |
|
@skonto: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ? |
|
@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ReToCode
merged commit 1bddfbd
into
openshift-knative:release-v1.15
34 of 69 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Back-ports:
Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVKS-1273
Does this PR needs for other branches:
No, will be included from 1.16+ from upstream
Does this PR (patch) needs to update/drop in the future?:
No
/assign @skonto