Use istio.sidecar.inject label instead of annotation #15522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15522 +/- ##
==========================================
+ Coverage 84.45% 84.48% +0.02%
==========================================
Files 219 219
Lines 13608 13608
==========================================
+ Hits 11493 11497 +4
+ Misses 1742 1740 -2
+ Partials 373 371 -2 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold See comment here: knative-extensions/net-istio#1369 (comment) |
knative-prow
bot
added
the
do-not-merge/hold
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
ReToCode
added a commit
to ReToCode/serving
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 0ebef64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially #15521
Proposed Changes
/assign @skonto