Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Add function name as identifier in antlr #1018

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2938890 from #1015

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 2938890)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 3, 2022 05:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1018 (f0bbb7b) into 2.4 (3e17e23) will decrease coverage by 2.63%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.4    #1018      +/-   ##
============================================
- Coverage     98.22%   95.58%   -2.64%     
+ Complexity     3272     3268       -4     
============================================
  Files           314      324      +10     
  Lines          8205     8855     +650     
  Branches        535      652     +117     
============================================
+ Hits           8059     8464     +405     
- Misses          142      334     +192     
- Partials          4       57      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit 7a6f71c into 2.4 Nov 3, 2022
@github-actions github-actions bot deleted the backport/backport-1015-to-2.4 branch November 3, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants