Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function name as identifier in antlr #1015

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Nov 3, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

  • Add function name as identifier in ANTLR.
  • Remove literal function support, includes
    • current_timestamp
    • localtimestamp
    • localtime
    • current_time
    • current_date

Issues Resolved

opensearch-project/observability#828
#672

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1015 (9cf1e90) into 2.x (21373b9) will decrease coverage by 2.63%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1015      +/-   ##
============================================
- Coverage     98.22%   95.58%   -2.64%     
+ Complexity     3272     3268       -4     
============================================
  Files           314      324      +10     
  Lines          8205     8855     +650     
  Branches        535      652     +117     
============================================
+ Hits           8059     8464     +405     
- Misses          142      334     +192     
- Partials          4       57      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo marked this pull request as ready for review November 3, 2022 02:36
@penghuo penghuo requested a review from a team as a code owner November 3, 2022 02:36
@penghuo penghuo self-assigned this Nov 3, 2022
@penghuo penghuo changed the title Add function name as identifier Add function name as identifier in antlr Nov 3, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit 2938890 into opensearch-project:2.x Nov 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 2938890)
penghuo added a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 2938890)

Co-authored-by: Peng Huo <penghuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants