Backport add CreateAlertTool (#349) #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add CreateAlertTool Signed-off-by: Heng Qian <qianheng@amazon.com> * spotlessApply and address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * add IT for CreateAlertTool Signed-off-by: Heng Qian <qianheng@amazon.com> * address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * fix after merging main Signed-off-by: Heng Qian <qianheng@amazon.com> * fix forbidden API Signed-off-by: Heng Qian <qianheng@amazon.com> * fix IT failure Signed-off-by: Heng Qian <qianheng@amazon.com> * run spotlessCheck Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments of changing getIndex to use ActionListener Signed-off-by: Heng Qian <qianheng@amazon.com> * fix IT Signed-off-by: Heng Qian <qianheng@amazon.com> * make prompt dict static Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
force-pushed
the
backport/backport-349-to-2.x
branch
from
448f6ed to
3b49e97
Compare
qianheng-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
qianheng-aws
changed the title
|
@qianheng-aws Can you update the PR description? |
Right, please add original PR link in the description. |
* Fix gradle task forbiddenApisMain failure Signed-off-by: zane-neo <zaniu@amazon.com> * fix compilation error since AD change Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> (cherry picked from commit 3e63a62) Signed-off-by: Heng Qian <qianheng@amazon.com>
yuye-aws
reviewed
Nov 4, 2024
| @@ -275,7 +275,7 @@ public void init(Client client) { | |||
| @Override | |||
| public CreateAlertTool create(Map<String, Object> params) { | |||
| String modelId = (String) params.get(MODEL_ID); | |||
| if (Strings.isBlank(modelId)) { | |||
| if (org.apache.commons.lang3.StringUtils.isBlank(modelId)) { | |||
There was a problem hiding this comment.
Can you import the StringUtils?
There was a problem hiding this comment.
It's cherry-picked from PR #391, We better not change it in this backport PR.
I think if we need to fix it, we better fix in in main branch and backport it to 2.x
There was a problem hiding this comment.
Oh I see. Is there any reason why you are directly using org.apache.commons.lang3.StringUtils.isBlank instead of importing it?
zane-neo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original PR: #349
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.