-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle task forbiddenApisMain failure #391
Fix gradle task forbiddenApisMain failure #391
Conversation
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
============================================
- Coverage 81.78% 81.28% -0.51%
- Complexity 193 246 +53
============================================
Files 11 14 +3
Lines 961 1261 +300
Branches 137 178 +41
============================================
+ Hits 786 1025 +239
- Misses 121 167 +46
- Partials 54 69 +15 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-391-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3e63a626029cc4d6fc64ca3143d14aefc7f3a27d
# Push it to GitHub
git push --set-upstream origin backport/backport-391-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x Then, create a pull request where the |
* Fix gradle task forbiddenApisMain failure Signed-off-by: zane-neo <zaniu@amazon.com> * fix compilation error since AD change Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> (cherry picked from commit 3e63a62) Signed-off-by: Heng Qian <qianheng@amazon.com>
* add CreateAlertTool (#349) * add CreateAlertTool Signed-off-by: Heng Qian <qianheng@amazon.com> * spotlessApply and address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * add IT for CreateAlertTool Signed-off-by: Heng Qian <qianheng@amazon.com> * address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * fix after merging main Signed-off-by: Heng Qian <qianheng@amazon.com> * fix forbidden API Signed-off-by: Heng Qian <qianheng@amazon.com> * fix IT failure Signed-off-by: Heng Qian <qianheng@amazon.com> * run spotlessCheck Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments of changing getIndex to use ActionListener Signed-off-by: Heng Qian <qianheng@amazon.com> * fix IT Signed-off-by: Heng Qian <qianheng@amazon.com> * make prompt dict static Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix gradle task forbiddenApisMain failure (#391) * Fix gradle task forbiddenApisMain failure Signed-off-by: zane-neo <zaniu@amazon.com> * fix compilation error since AD change Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> (cherry picked from commit 3e63a62) Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: zane-neo <zaniu@amazon.com> Co-authored-by: zane-neo <zaniu@amazon.com>
Description
Fix gradle task forbiddenApisMain failure
Fix compilation failure caused by AD change
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.