-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt new changelog standard #1821
Conversation
Added new human readable changelog for 2.0.0-rc1 and including unreleased commits. The release process we've been using for release-notes has not been producing useful results, there has been discussion in opensearch-project/OpenSearch#1868 to come up with a practice. This is an attempt to start following the suggestion and come up with feedback for the OpenSearch organization. Signed-off-by: Peter Nied <petern@amazon.com>
@@ -0,0 +1,62 @@ | |||
# Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation use Rich Diff
to see this file with the markdown rendered.
CHANGELOG.md
Outdated
* Security patch for `org.apache.kafka:kafka-clients` | ||
* Security patch for `org.springframework.kafka:spring-kafka-test` | ||
|
||
## [2.0.0-rc1] - 2022-04-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is comparable to https://github.com/opensearch-project/security/blob/main/release-notes/opensearch-security.release-notes-2.0.0.0-rc1.md#2022-04-20-version-2000-rc1
Note; I've collapsed/omitted several updates by maintainers, it might be worthwhile discussion why we should/shouldn't include some of those items.
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
=========================================
Coverage 60.80% 60.81%
- Complexity 3186 3187 +1
=========================================
Files 253 253
Lines 17931 17943 +12
Branches 3204 3205 +1
=========================================
+ Hits 10903 10912 +9
Misses 5451 5451
- Partials 1577 1580 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All the changes need a link to the PR that made that change.
- I would develop this as a mechanism for all plugins and core and release in unison, wouldn't want just security plugin to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also my comment on opensearch-project/OpenSearch#1868 (comment)
Very true @dblock; however, that source issue is very much abstract. For the sake generating feedback with a digestible example I started this effort. The 'practice' documentation should move into the meta repository for ratification - did you have thoughts on staging this differently that is being done in this PR? |
Signed-off-by: Peter Nied <petern@amazon.com>
Per your comments @dblock
Done.
My thoughts were first by making this change it could help answer the question 'What does this look like' and create a focal point for discussion. It sounds like you would also want a check on pull requests that would make sure this process was not overlooked - what do you think about making a separate issue in opensearch-project/OpenSearch to track this? |
Signed-off-by: Peter Nied <petern@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, thanks!
There've been the release drafter to generate draft release notes capturing all merged PRs. Why is this changelog needed? |
@cliu123 This changelog isn't machine generated, its human generated. I believe that offers a huge leap in readability. What do you think of the utility of this changelog vs the git log generated release notes? |
This is a good idea that makes changelog available before release! It'd be perfect if it's done automatially instead of manually. It'd be very easy to forget to update CHANGELOG.md on each PR especially for new contributors who are not familiar with our develpment process. In comparison, the release drafter run in CI automatically documents the changes, which makes more sense. |
Being that there is still some contention with enforcement, I'm going to close this PR. When the time comes that we can broach this topic I'll see about reopening. Thanks everyone for your consideration. |
Description
Added new human readable changelog for 2.0.0-rc1 and including
unreleased commits.
The release process we've been using for release-notes has not been
producing useful results, there has been discussion in
opensearch-project/OpenSearch#1868 to come up
with a practice. This is an attempt to start following the suggestion
and come up with feedback for the OpenSearch organization.
Signed-off-by: Peter Nied petern@amazon.com
Issues Resolved
Check List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.