Skip to content

Commit

Permalink
Addressing feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Peter Nied <petern@amazon.com>
  • Loading branch information
peternied committed May 10, 2022
1 parent b755b2d commit 400f804
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 32 deletions.
65 changes: 36 additions & 29 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,56 +7,63 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added
### Changed
* [[#1798](https://github.com/opensearch-project/security/pull/1798)] Changed behavior when certificates are reloaded allowing reloading of the same certificate.
* [[#1821](https://github.com/opensearch-project/security/pull/1821)] Changed from release-notes to CHANGELOG.md.

* Integrating APIs with security from [@ohltyler](https://github.com/ohltyler)
### Removed
* [[#1773](https://github.com/opensearch-project/security/pull/1773)] Removed `advanced_modules_enabled` examples that were outdated.

### Changed
* Corrected ml/stats/nodes permissions spelling from [@camAtGitHub](https://github.com/camAtGitHub)
* Internal user usage clarification from [@reshippie](https://github.com/reshippie)
* Remove `advanced_modules_enabled` examples from [@wjordan](https://github.com/wjordan)
* CHANGELOG.md replaces release-notes
### Fixed
* [[#1784](https://github.com/opensearch-project/security/pull/1784)] Fixed internal users configuration documentation to include the source role.
* [[#1770](https://github.com/opensearch-project/security/pull/1770)] Fixed incorrect spelling in `cluster:admin/opensearch/ml/stats/nodes` permissions.

### Security

* Security patch for `org.cryptacular:cryptacular`
* Security patch for `org.springframework:spring-core`
* Security patch for `org.apache.kafka:kafka-clients`
* Security patch for `org.springframework.kafka:spring-kafka-test`
* [[#1806](https://github.com/opensearch-project/security/pull/1806)] Update `org.cryptacular:cryptacular` to `1.2.4`, [CVE-2020-15522].
* [[#1806](https://github.com/opensearch-project/security/pull/1806)] Updated `org.springframework:spring-core` to `5.3.19`, [CVE-2022-22968], [CVE-2022-22965], [CVE-2022-22950].
* [[#1806](https://github.com/opensearch-project/security/pull/1806)] Updated `org.apache.kafka:kafka-clients` to `3.0.0`, [CVE-2020-36518].
* [[#1806](https://github.com/opensearch-project/security/pull/1806)] Updated `org.springframework.kafka:spring-kafka-test` to `2.8.5`, [CVE-2021-45105], [CVE-2021-45046], [CVE-2021-44832], [CVE-2021-44228].

## [2.0.0-rc1] - 2022-04-20
## [2.0.0.0-rc1] - 2022-04-20

### Added

* DLS privileges evaluation can process security roles from [@ch-govau](https://github.com/ch-govau)
* Setting to enable role without DLS/FLS to override roles
* DLS Term Lookup Queries
* [[#1609](https://github.com/opensearch-project/security/pull/1609)] Added support for JDK17.
* [[#1710](https://github.com/opensearch-project/security/pull/1710)] Added support for Gradle 7.
* [[#1753](https://github.com/opensearch-project/security/pull/1735)] Added setting `dfm_empty_overrides_all` to prioritize privileges evulation of security roles without Document Level Security restrictions.
* [[#1508](https://github.com/opensearch-project/security/issues/1508)] Added support for Terms Lookup Queries in Document Level Security, see [the documentation](https://opensearch.org/docs/2.0/security-plugin/access-control/document-level-security/#use-term-level-lookup-queries-tlqs-with-dls) for further details.

### Changed

* Support for JDK17
* Support for Gradle 7
* Use standard Issue/Pull request templates from [@dblock](https://github.com/dblock)
* Security configuration are placed side-by-side with other plugins
* Cleaned up developer guide
* [[#1749](https://github.com/opensearch-project/security/pull/1749)] Changed security configuration placement to be side-by-side with other plugins in the OpenSearch config directory.

### Deprecated

* Security tools deprecation
* [[1756](https://github.com/opensearch-project/security/issues/1756)] Deprecated security tools, audit config migrater, hash, security admin, install demo configuration scripts marked as deprecated, see the [deprecation notice](https://github.com/opensearch-project/security/issues/1755) to learn more, replacement plans are still pending.

### Removed

* No longer supporting JDK14
* Removed TransportClient
* [[#1718](https://github.com/opensearch-project/security/issues/1718)] Removed support for JDK14. In the future only LTS versions of the JDK will be supported.

### Fixed

* Log messages are sent to the OpenSearch log, reported by [@patcable](https://github.com/patcable)
* Wild-card expressions are properly invalidate from [@sandeshkr419](https://github.com/sandeshkr419)
* DLS replication action failure reports correct failure from [@saikaranam-amazon](https://github.com/saikaranam-amazon)
* Improvement to test speed / reliability
* Backward compataiblity tests download binaries, rather than use a checked in binary
* [[#1751](https://github.com/opensearch-project/security/pull/1751)] Fixed missing log message output in OpenSearch log.

### Security

* DLS `min_doc_count` of zero will no longer disclose aggregate keys that user does not have permissions to see
* [[#1723](https://github.com/opensearch-project/security/pull/1723)] Fixed data exfiltration of index names when wild-card expressions are evalutted.
* [[#1714](https://github.com/opensearch-project/security/pull/1714)] Fixed data exfiltration of string terms when `min_doc_count` was set to zero.


[unreleased]: https://github.com/opensearch-project/security/compare/2.0.0.0-rc1...HEAD
[2.0.0.0-rc1]: https://github.com/opensearch-project/security/compare/1.3.0.0...2.0.0.0-rc1
[CVE-2020-15522]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15522
[CVE-2022-22968]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22968
[CVE-2022-22965]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22965
[CVE-2022-22950]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22950
[CVE-2020-36518]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-36518
[CVE-2021-45105]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45105
[CVE-2021-45046]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45046
[CVE-2021-44832]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44832
[CVE-2021-44228]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44228
6 changes: 3 additions & 3 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ To ensure common practices as maintainers, all practices are expected to be docu
# Practices

## Release Notes
During all pull requests the maintainers will make sure that release notes have been created/updated. To make these release notes more consistant follow the format described by https://keepachangelog.com/en/1.0.0/. Work will mostly happen in the `[Unreleased]` section of the log, there are six subcategories of change: Added, Changed, Deprecated, Removed, Fixed, Security. There can be changes that do not add entries to the changelog when it is useful for humans, such as modifications to the changelog itself.
During all pull requests the maintainers will make sure that release notes have been created/updated. To make these release notes more consistant follow the format described by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Work will mostly happen in the `[Unreleased]` section of the log, there are six subcategories of change: Added, Changed, Deprecated, Removed, Fixed, Security. There can be changes that do not add entries to the changelog when it is useful for humans, such as modifications to the changelog itself.

```
# Changelog
Expand All @@ -35,8 +35,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [1.0.0] - 2017-06-20
### Added
- New visual identity by [@tylerfortune8](https://github.com/tylerfortune8).
- Version navigation.
- [[#PR_NUMBER)[#LINK]] Added user pictures in identity panel.
- [[#PR_NUMBER)[#LINK]] Added version navigation between blitz and chitz.
```

Expand Down

0 comments on commit 400f804

Please sign in to comment.