Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] [1.x] Update detekt and ktlint version #557

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8aeab12 from #556

* Update detekt, ktlint and snakeyaml

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix detekt build failure

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update ktlint version to 0.45.1 (#521)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix ktlint build errors

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
(cherry picked from commit 8aeab12)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 1, 2022 20:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #557 (95d14a3) into 1.3 (411590f) will increase coverage by 0.22%.
The diff coverage is 88.49%.

@@             Coverage Diff              @@
##                1.3     #557      +/-   ##
============================================
+ Coverage     74.35%   74.57%   +0.22%     
  Complexity      383      383              
============================================
  Files            94       94              
  Lines          3969     4008      +39     
  Branches        612      612              
============================================
+ Hits           2951     2989      +38     
- Misses          884      885       +1     
  Partials        134      134              
Flag Coverage Δ
dashboards-reports 77.06% <ø> (ø)
reports-scheduler 72.30% <88.49%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nsearch/reportsscheduler/ReportsSchedulerPlugin.kt 100.00% <ø> (ø)
...search/reportsscheduler/action/PluginBaseAction.kt 31.34% <ø> (ø)
...tsscheduler/model/CreateReportDefinitionRequest.kt 73.07% <ø> (ø)
...sscheduler/model/CreateReportDefinitionResponse.kt 100.00% <ø> (ø)
...tsscheduler/model/DeleteReportDefinitionRequest.kt 67.85% <ø> (ø)
...sscheduler/model/DeleteReportDefinitionResponse.kt 87.50% <ø> (ø)
...sscheduler/model/GetAllReportDefinitionsRequest.kt 62.85% <ø> (ø)
...scheduler/model/GetAllReportDefinitionsResponse.kt 84.61% <ø> (ø)
...rtsscheduler/model/GetAllReportInstancesRequest.kt 62.85% <ø> (ø)
...tsscheduler/model/GetAllReportInstancesResponse.kt 84.61% <ø> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rupal-bq rupal-bq merged commit a17d1a4 into 1.3 Dec 1, 2022
@github-actions github-actions bot deleted the backport/backport-556-to-1.3 branch December 1, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants