[1.x] Update detekt and ktlint version #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
joshuali925
approved these changes
Dec 1, 2022
Codecov Report
@@ Coverage Diff @@
## 1.x #556 +/- ##
============================================
+ Coverage 74.35% 77.06% +2.71%
============================================
Files 94 30 -64
Lines 3969 1910 -2059
Branches 612 383 -229
============================================
- Hits 2951 1472 -1479
+ Misses 884 435 -449
+ Partials 134 3 -131
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sejli
approved these changes
Dec 1, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Update detekt, ktlint and snakeyaml Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix detekt build failure Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update ktlint version to 0.45.1 (#521) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix ktlint build errors Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 8aeab12)
rupal-bq
added a commit
that referenced
this pull request
Dec 1, 2022
* Update detekt, ktlint and snakeyaml Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix detekt build failure Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update ktlint version to 0.45.1 (#521) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix ktlint build errors Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 8aeab12) Co-authored-by: Rupal Mahajan <maharup@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading detekt, snakyaml, and ktlint to resolve CVE
Issues Resolved
CVE-2022-0272
CVE-2022-25857
CVE-2022-38750
CVE-2022-38752
CVE-2022-41854
CVE-2015-5262
CVE-2020-13956
CVE-2022-38751
CVE-2018-10237
CVE-2022-38749
CVE-2020-8908
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.