Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Data Prepper 1.2.1 archives. #622

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Jan 13, 2022

Description

This PR adds Data Prepper archive files for Linux.

Additionally, Data Prepper includes a bundle without an embedded JDK. I took the approach of referring users to the archives directory for this artifact. This is similar to how the OpenDistro Data Prepper download page worked.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

…the Data Prepper description to get access to a version with a bundled JDK.

Signed-off-by: David Venable <dlv@amazon.com>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - what is the "suggested" artifact - docker or tar?

@dlvenable
Copy link
Member Author

@stockholmux , What do you mean by "suggested" artifact. We'd like to encourage users to download the Dockerfile.

Signed-off-by: David Venable <dlv@amazon.com>
…the order.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable
Copy link
Member Author

@stockholmux , Thanks for the suggestion! I updated the platform_order so that Docker comes before Linux. Now it is selected by default for Data Prepper.

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stockholmux stockholmux merged commit f477e47 into opensearch-project:main Jan 14, 2022
@stockholmux
Copy link
Member

@dlvenable Thanks for the PR!

Maybe in the future we should figure out a more graceful way to deal with the no-JDK option, but the way you did it works for now so no changes needed.

@dlvenable
Copy link
Member Author

Thanks for merging @stockholmux . I created #624 as a feature request to better support the no-JDK download option.

@dlvenable dlvenable deleted the data-prepper-1.2.1-tar branch October 20, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants