Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for archives with or without JDK #624

Open
dlvenable opened this issue Jan 14, 2022 · 3 comments
Open

Better support for archives with or without JDK #624

dlvenable opened this issue Jan 14, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Data Prepper releases two bundles for Linux archives:

  1. The primary one includes a bundled JDK
  2. The second one does not have a bundled JDK

The Data Prepper download page has a small blurb that lets users know they can download it without a bundled JDK on the archives page. It reads:

Distributions without a bundled JDK are also available in the artifacts directory.

There should be a better way to select the option to download without a bundled JDK.

Describe the solution you'd like

I think it would be nice to have a new drop-down option for one with a bundled JDK or without a bundled JDK. Maybe it could even be a checkbox. But, we'd probably not want this if every application is forced to have this option.

The options could be:

  • Includes bundled JDK
  • Without bundled JDK.

Describe alternatives you've considered

One approach would be that this download option comes through a new drop-down option in the existing "Platform" drop-down. Perhaps the options become:

  • Linux / bundled JDK
  • Linux / without bundled JDK

A similar approach would be a new option in the existing "Packaging" drop-down. This makes some sense because what is packaged is different. But, right now "Package" is the way it is packaged.

  • tar.gz / bundled JDK
  • tar.gz / without bundled JDK

Another approach would be to have a second "application" below Data Prepper. It could be named "Data Prepper (without bundled JDK)". This seems to make this project a different applications and seems it can be confusing. Also, would this have other similar download options to Data Prepper? I'd rather not take this approach.

Additional context

The current approach of using text was added in #622.

@dlvenable dlvenable added the enhancement New feature or request label Jan 14, 2022
@stockholmux
Copy link
Member

Thanks @dlvenable - this is a good issue.

I lean a little bit towards the JDK/No-JDK being a packing option, but it does stretch how the word is used on the page.

Perhaps we can get contextual a little bit on this - do you see the JDK/no-JDK distributions(packages?) being of equal importance? Or would No-JDK we something a niche of folks would use?

If it is small number we could also implement the download link as we do with file signatures - a simple link below the download "button".

Example (text is flexible):
Screen Shot 2022-01-17 at 9 59 59 AM

@dlvenable
Copy link
Member Author

@stockholmux , I am unsure how many users will choose JDK versus no-JDK. We will probably want to watch the download numbers to see.

Regarding the idea of a small download button, I like this idea. It is not far off from my proposed solution with a checkbox.

But, I also want to be sure that the signature file is available for download. I noticed that the current archives directory does not include signature files. So right now you can't download the no-JDK and the signature file (unless you manually craft the URL).

@stockholmux
Copy link
Member

@dlvenable OK. Getting the no JDK as an "Extra" link is a relatively short path. I'll work on that.

Good point on the sig files on the artifacts directory. I'll whip up an issue on that independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants