Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Service/Stat Metrics #376

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented May 26, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
opensearch-project/performance-analyzer-commons#8

Describe alternatives you've considered
RCA side change to Service Metric Refactoring, see details Commons change at opensearch-project/performance-analyzer-commons#14

  • Tested with MavenLocal build of Commons and spinning up a Docker container
------------------------------------------------------------------------
Program=PerformanceAnalyzerAgent
rca-version=0.0.1
Metrics=MetricsdbFileSize=155648 bytes aggr|MAX,MetricsdbFileSize=155648.0 bytes aggr|MEAN
StartTime=1685086391.898
EndTime=Fri, 26 May 2023 07:35:09 UTC
Time=117451 msecs
Timing=GCInfoEmitterExecutionTime:58.0/1,total-time:117451.0/1,ClusterManagerThrottlingEmitterExecutionTime:60.0/1,ClusterManagerEventMetricsEmitterExecutionTime:94.0/1,ReaderMetricsProcessTime:5653.0/1,AggregatedOSMetricsEmitterExecutionTime:244.0/1,ThreadNameMetricsEmitterExecutionTime:14.0/1,HTTPMetricsEmitterExecutionTime:62.0/1,ReaderOSMetricsEmitTime:386.0/1,AdmissionControlMetricsEmitterExecutionTime:93.0/1,ShardRequestMetricsEmitterExecutionTime:799.0/1,ReaderMetricsEmitTime:4291.0/1,FaultDetectionMetricsEmitterExecutionTime:62.0/1,WorkloadMetricsEmitterExecutionTime:55.0/1,ShardStateEmitterExecutionTime:32.0/1
Counters=
EOE

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

khushbr added 2 commits May 25, 2023 13:45
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@khushbr khushbr changed the title Main 1 Refactoring Service/Stat Metrics May 26, 2023
@khushbr khushbr merged commit 7ba9df5 into opensearch-project:main May 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2023
* Updating the code for service metric change in commons

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

* Refactoring code, fixing UTs

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

---------

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 7ba9df5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2023
* Updating the code for service metric change in commons

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

* Refactoring code, fixing UTs

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

---------

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 7ba9df5)
khushbr added a commit that referenced this pull request May 30, 2023
* Updating the code for service metric change in commons

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

* Refactoring code, fixing UTs

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

---------

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 7ba9df5)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
khushbr added a commit that referenced this pull request May 30, 2023
* Updating the code for service metric change in commons

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

* Refactoring code, fixing UTs

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

---------

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 7ba9df5)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants