Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Service/Stat Metrics #14

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented May 25, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#8

Describe the solution you are proposing

  • Refactor Service/Stat Metric Codebase
  • The emitMetrics Service metric is currently working only for ES versions. All the timers are currently broken for OS version.
  • Add Inherent support for service metrics in Collector Framework

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@Tjofil
Copy link
Contributor

Tjofil commented May 25, 2023

In commons/stats/eval/impl/vals, subpackages sound generic and don't have much meaning, do we keep them, rename them or flatten them back ?

@khushbr
Copy link
Collaborator Author

khushbr commented May 25, 2023

In commons/stats/eval/impl/vals, subpackages sound generic and don't have much meaning, do we keep them, rename them or flatten them back ?

We can later revisit and flatten this out. I wanted to keep this consistent with directory structure in RCA package to ensure we don't miss any of the files. The README is also arranged as per the structure, we can update both later.

@khushbr khushbr merged commit b61e646 into opensearch-project:main May 25, 2023
@Tjofil Tjofil mentioned this pull request May 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants