Codecov Tokenless upload #1155
Draft
Codecov Tokenless upload #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreKurait
force-pushed
the
CodeCovNoTokenTest
branch
2 times, most recently
from
f003574 to
635d671
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=========================================
Coverage 80.76% 80.76%
Complexity 2948 2948
=========================================
Files 400 400
Lines 15104 15104
Branches 1021 1021
=========================================
Hits 12199 12199
Misses 2288 2288
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
AndreKurait
force-pushed
the
CodeCovNoTokenTest
branch
2 times, most recently
from
b9145a2 to
0c3acd7
Compare
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
peternied
reviewed
Nov 22, 2024
peternied
approved these changes
Nov 22, 2024
Signed-off-by: Andre Kurait <akurait@amazon.com>
AndreKurait
force-pushed
the
CodeCovNoTokenTest
branch
from
f9d9180 to
986b024
Compare
|
Pending fix codecov/codecov-action#1704 |
|
Since this is waiting on a downstream fix, going to mark this as draft until we know its ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved to a more complex workflow_run trigger due to issues codecov had with tokenless uploads for the past few months.
This was reported in codecov/codecov-action#1580 and recently resolved with version
5.0.7.This change moves back to tokenless uploads which reduces risk and makes it easier to test any future updates and adds some support for codecov updates even with some test failures.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.