Inconsistent - Token required because branch is protected #1580
Assignees
Labels
Area: Report Upload
Issues with pre-ingest report uploading
bug
Something isn't working
high
High Priority Issues (to be fixed within 2 sprints)
Comments
4 tasks
|
Workaround is to close the PR and make a new one e.g. opensearch-project/opensearch-migrations#1019 |
|
I'm getting this quite a lot suddenly on https://github.com/google/osv-scanner - this only started happening in the last couple of weeks and afaik there have not been any changes to the branch protection rules (@another-rex could you confirm this?) Some action examples: |
3 tasks
|
@thomasrockhu can you please look into this one? 🙏 |
|
@thomasrockhu-codecov seems to be a better handle to ping :) |
thomasrockhu-codecov
added
bug
|
@greg0ire @AndreKurait noting that I see this. Am asking the team what the expected behavior is but from what I can tell, we have always had protected branches require a token. @AndreKurait have you seen this come up again or was it that one time? |
|
@G-Rath please let me know if there was a change in branch protection rules |
|
@thomasrockhu-codecov I don't know as I'm not the owner of the repository, but I've not seen this failure for a few weeks so I assume it's just been fixed 🤷 |
|
@thomasrockhu-codecov I no longer see the _error message on my repository, but I still have an issue: the upload is never processed. I will file a separate bug report. |
|
Here it is: #1633 |
|
Going to close this one out for now, @greg0ire I'll take a look at that issue |
|
@thomasrockhu-codecov I just hit this again, can we reopen this? I only ever get it after pushing multiple commits after creating a PR. It appears to be a bug in detecting the fork |
|
It's inconsistent because another action on the same commit passed |
|
@AndreKurait got it, taking a look |
|
@AndreKurait everything ok? I got a message in my email and just wanted to double-check |
|
We had some failures tonight with a new error message. Made some PRs which passed, and some failed. I have a suspicion there's some throttling limits involved, so i set up some actions to retry 20 times, and observed this error message occur consistently. I looked into our use of tokens, and saw we were triggering our action on |
|
found it |
|
@AndreKurait we pushed a fix for this earlier today, can you try again? |
|
@thomasrockhu-codecov just wanted to share we've had no issues so far, around 3-4 PRs across 2-3 repos since then. |
This comment has been minimized.
This comment has been minimized.
|
This is still broken for me
Full output |
|
@KATT do you mind trying on |
|
We use I can't test it without creating a new github user etc, so I'll see whenever a new PR drops in next, I force-merged the aforementioned one |
|
@KATT just wanted to ping back here and see if there's anything I can help with. |
|
@AndreKurait just wanted to check back and see if this was working for you |
4 tasks
|
I'm seeing resolution and working tokenless uploads on 5.0.5 Working LogsAnd 5.0.6 Failed Logs |
|
@AndreKurait on it, thanks |
|
@AndreKurait can you try |
|
@thomasrockhu-codecov v5.0.7 is working reliably. This has been a rough few months for us using codecov, do we have any tests added to ensure this continues to work as expected? |
|
@AndreKurait I'm so sorry that your experience has been pretty rough, that's obviously not our intention. We have built out some tests regarding the v5 release internally and I'll be building out some more infrastructure that is exposed to open source. There are definitely some cases we missed that we shouldn't have, and that's my fault. I am hoping that the silver lining for the issues in this release have been the attention and speed of fixes to the problems. If you have any suggestions on what else we can be doing better, please let me know. Given that I believe everyone in this thread has had their issues resolved, I'm closing this issue. |
This was referenced Nov 26, 2024
This was referenced Dec 14, 2024
nicklan
added a commit
to delta-io/delta-kernel-rs
that referenced
this issue
Dec 19, 2024
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-incubator/delta-kernel-rs/blob/main/CONTRIBUTING.md 2. Run `cargo t --all-features --all-targets` to get started testing, and run `cargo fmt`. 3. Ensure you have added or run the appropriate tests for your PR. 4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 5. Be sure to keep the PR description updated to reflect all changes. --> ## What changes are proposed in this pull request? <!-- Please clarify what changes you are proposing and why the changes are needed. The purpose of this section is to outline the changes, why they are needed, and how this PR fixes the issue. If the reason for the change is already explained clearly in an issue, then it does not need to be restated here. 1. If you propose a new API or feature, clarify the use case for a new API or feature. 2. If you fix a bug, you can clarify why it is a bug. --> V5 seems to resolve a number of issues, include [this one](codecov/codecov-action#1580) which happens in our repo [for sure](https://github.com/delta-io/delta-kernel-rs/actions/runs/12403987305/job/34628440507?pr=607). This just updates to that. <!-- Uncomment this section if there are any changes affecting public APIs: ### This PR affects the following public APIs If there are breaking changes, please ensure the `breaking-changes` label gets added by CI, and describe why the changes are needed. Note that _new_ public APIs are not considered breaking. --> ## How was this change tested? <!-- Please make sure to add test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested, ideally via a reproducible test documented in the PR description. -->
lebrice
added a commit
to lebrice/milatools
that referenced
this issue
Dec 19, 2024
Getting inconsistent errors in CI, maybe due to a codecov issue? - Example: https://github.com/mila-iqia/milatools/actions/runs/12419445408/job/34676165915?pr=137 - Issue on the CodeCov action repo: codecov/codecov-action#1580 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
lebrice
added a commit
to mila-iqia/milatools
that referenced
this issue
Dec 20, 2024
* Switch from Poetry to UV Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Fix pre-commit issues, get removesuffix from `str` Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Remove poetry.lock Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Add missing uv.lock file Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Add missing pytest-skip-slow test dependency Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Fix issue in testing.yml reusable workflow Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Update codecov action (?) Getting inconsistent errors in CI, maybe due to a codecov issue? - Example: https://github.com/mila-iqia/milatools/actions/runs/12419445408/job/34676165915?pr=137 - Issue on the CodeCov action repo: codecov/codecov-action#1580 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> --------- Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On a public repo, i'm getting inconsistent results with codecov-v4
e.g. opensearch-project/opensearch-migrations#1016
First Run - Successful
Subsequent Run - Failure
The text was updated successfully, but these errors were encountered: