[Backport 2.x] [Improvement] fix issue with tenancy and test finder #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149)
tianleh
approved these changes
Jun 3, 2022
CCongWang
pushed a commit
that referenced
this pull request
Feb 10, 2023
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Cong Wang <conjwang@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e355149 from #236