Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] fix issue with tenancy and test finder #236

Merged
merged 1 commit into from
Jun 3, 2022
Merged

[Improvement] fix issue with tenancy and test finder #236

merged 1 commit into from
Jun 3, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented May 31, 2022 •
edited
Loading

Description

Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavilla
[Improvement] fix issue with tenancy and test finder
610ac41 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner May 31, 2022 19:36
@kavilla kavilla added bug Something isn't working backport 2.x backport 2.0 labels May 31, 2022
@kavilla kavilla merged commit e355149 into opensearch-project:main Jun 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 3, 2022
@kavilla @github-actions
[Improvement] fix issue with tenancy and test finder (#236)
5ef94d1 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e355149)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 3, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 3, 2022
@kavilla @github-actions
[Improvement] fix issue with tenancy and test finder (#236)
aaab6f3 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e355149)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 3, 2022
Merged
@kavilla kavilla deleted the avillk/fix_tenancy_issue branch June 3, 2022 16:19
kavilla added a commit that referenced this pull request Jun 3, 2022
@opensearch-trigger-bot @kavilla
[Improvement] fix issue with tenancy and test finder (#236) (#239)
cb4f64b 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e355149)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Jun 3, 2022
@opensearch-trigger-bot @kavilla
[Improvement] fix issue with tenancy and test finder (#236) (#240)
8e10269 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e355149)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
@opensearch-trigger-bot @kavilla
[Improvement] fix issue with tenancy and test finder (#236) (#239)
5610f62 
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e355149)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Cong Wang <conjwang@amazon.com>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
@kavilla @jakubp-eliatra
[Improvement] fix issue with tenancy and test finder (opensearch-proj…
c532d8a 
…ect#236)

Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.

Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.

Issue:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
@Divyaasm Divyaasm mentioned this pull request May 15, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianleh tianleh tianleh approved these changes

@davidcui1225 davidcui1225 Awaiting requested review from davidcui1225

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavilla @tianleh