-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] fix issue with tenancy and test finder #236
Merged
kavilla
merged 1 commit into
opensearch-project:main
from
kavilla:avillk/fix_tenancy_issue
Jun 3, 2022
Merged
[Improvement] fix issue with tenancy and test finder #236
kavilla
merged 1 commit into
opensearch-project:main
from
kavilla:avillk/fix_tenancy_issue
Jun 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
davidcui1225,
CCongWang,
peterzhuamazon and
tianleh
May 31, 2022 19:38
tianleh
approved these changes
Jun 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149)
kavilla
added a commit
that referenced
this pull request
Jun 3, 2022
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Jun 3, 2022
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
CCongWang
pushed a commit
that referenced
this pull request
Feb 10, 2023
Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e355149) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Cong Wang <conjwang@amazon.com>
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
…ect#236) Incorrectly merged the verification where I check if option to wait for switching of tenant worked. Switched it back to the expected scenario if the test passed the command it will wait. Also, the test finder for manifest was missing the manifest path so added that while also ensuring the minify OSD tests weren't ran when verifying the distribution because those will fail as expected. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorrectly merged the verification where I check if option to wait
for switching of tenant worked. Switched it back to the expected
scenario if the test passed the command it will wait.
Also, the test finder for manifest was missing the manifest path so
added that while also ensuring the minify OSD tests weren't ran
when verifying the distribution because those will fail as expected.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.