-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notifications for 2.3 release #2581
Merged
rishabh6788
merged 3 commits into
opensearch-project:main
from
praveensameneni:add-notifications-alerting
Sep 8, 2022
Merged
Add Notifications for 2.3 release #2581
rishabh6788
merged 3 commits into
opensearch-project:main
from
praveensameneni:add-notifications-alerting
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #2581 +/- ##
============================================
- Coverage 94.41% 94.41% -0.01%
============================================
Files 219 162 -57
Lines 4462 4279 -183
Branches 29 19 -10
============================================
- Hits 4213 4040 -173
+ Misses 243 239 -4
+ Partials 6 0 -6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
… failure Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
rishabh6788
approved these changes
Sep 8, 2022
@rishabh6788 Could you merge this PR? I don't seem to have permissions to merge for this repo. |
Angie-Zhang
pushed a commit
to Angie-Zhang/opensearch-build
that referenced
this pull request
Sep 8, 2022
* Add Notifications for 2.3 release Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com> * Add Notifications for 2.3 release, fixed new line character yaml-lint failure Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com> * Add Notifications for 2.3 release, fix lint trailing spaces error Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com> Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: praveensameneni 50342543+praveensameneni@users.noreply.github.com
Description
Add Notifications, notifications-dashboards for 2.3 release
Issues Resolved
opensearch-project/notifications#516
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.