Added notifications plugin to 2.3 manifest files. #2551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2551 +/- ##
============================================
- Coverage 94.41% 91.66% -2.76%
Complexity 28 28
============================================
Files 219 63 -156
Lines 4462 288 -4174
Branches 29 29
============================================
- Hits 4213 264 -3949
+ Misses 243 18 -225
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
|
I'll revise this PR once the 2.3 branch is cut for the notifications plugin. |
|
Hey @AWSHurneyt can you please resolve the conflict as well. |
Will do. I'll fix the merge conflict when I adjust the |
…ch-build into 2.3release � Conflicts: � manifests/2.3.0/opensearch-2.3.0.yml � manifests/2.3.0/opensearch-dashboards-2.3.0.yml
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
force-pushed
the
2.3release
branch
from
14f9603 to
253de47
Compare
|
@AWSHurneyt Pleas fix merge-conflicts too. Thanks! |
gaiksaya
requested changes
Sep 8, 2022
…ch-build into 2.3release � Conflicts: � manifests/2.3.0/opensearch-2.3.0.yml � manifests/2.3.0/opensearch-dashboards-2.3.0.yml
AWSHurneyt
force-pushed
the
2.3release
branch
from
fe8352b to
6093193
Compare
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
|
Closing in favor of #2581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AWSHurneyt hurneyt@amazon.com
Description
Added notifications plugin to 2.3 manifest files.
Issues Resolved
opensearch-project/notifications#516
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.