Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Fixed Vertical & Horizontal Bar visualization issues #1156

Merged
merged 8 commits into from
Oct 22, 2022
Merged

[BUG]: Fixed Vertical & Horizontal Bar visualization issues #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3db5515
Fixed issue-1153
Koustubh5585 Oct 18, 2022
c415153
Fixed color theme issue of vertical bar chart
Koustubh5585 Oct 19, 2022
bf69b10
Merge branch 'main' into bug/visualization_vertical_bar
Koustubh5585 Oct 19, 2022
b2e328b
Fixed horizontal bar style and tooltip issue
Koustubh5585 Oct 19, 2022
1a1d788
Hide some visualization charts options
Koustubh5585 Oct 20, 2022
306d962
Updated snap files
Koustubh5585 Oct 20, 2022
fe096e2
Removed commented code
Koustubh5585 Oct 21, 2022
766aa20
Merge branch 'main' into bug/visualization_vertical_bar
Koustubh5585 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboards-observability/.cypress/integration/VisualizationCharts/13_stats_chart.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ describe('Render stats chart verfiy functionality for Tooltip text', () => {
cy.get('.euiButton__text.euiButtonGroupButton__textShift').eq(2).should('have.text', 'All');
cy.get('.euiButton__text.euiButtonGroupButton__textShift').eq(3).should('have.text', 'Dimension')
.click();
cy.get('.euiButton__text.euiButtonGroupButton__textShift').eq(4).should('have.text', 'Metrics')
cy.get('.euiButton__text.euiButtonGroupButton__textShift').eq(4).should('have.text', 'Series')
.click();
});
});
Expand Down
14 changes: 0 additions & 14 deletions dashboards-observability/common/constants/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ export enum VIS_CHART_TYPES {
Pie = 'pie',
HeatMap = 'heatmap',
Text = 'text',
Gauge = 'gauge',
Histogram = 'histogram',
TreeMap = 'tree_map',
Scatter = 'scatter',
LogsView = 'logs_view',
Metrics = 'metrics',
TableView = 'data_table',
}

export const NUMERICAL_FIELDS = ['short', 'integer', 'long', 'float', 'double'];
Expand All @@ -96,13 +89,6 @@ export const ENABLED_VIS_TYPES = [
VIS_CHART_TYPES.Pie,
VIS_CHART_TYPES.HeatMap,
VIS_CHART_TYPES.Text,
VIS_CHART_TYPES.TreeMap,
VIS_CHART_TYPES.Gauge,
VIS_CHART_TYPES.Histogram,
VIS_CHART_TYPES.Scatter,
VIS_CHART_TYPES.LogsView,
VIS_CHART_TYPES.Metrics,
VIS_CHART_TYPES.TableView,
];

// Live tail constants
Expand Down
24 changes: 12 additions & 12 deletions ...ility/public/components/custom_panels/helpers/__tests__/__snapshots__/utils.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -647,7 +647,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -1102,7 +1102,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -1699,7 +1699,7 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -2205,7 +2205,7 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -2725,7 +2725,7 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -3252,7 +3252,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -3700,7 +3700,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -4155,7 +4155,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -4634,7 +4634,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -5028,7 +5028,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down Expand Up @@ -5429,7 +5429,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"id": "y",
"name": "Metrics",
"name": "Series",
},
],
},
Expand Down
Loading